[STREAM-640] Push-Based Broker / Worker POC Protos#160
[STREAM-640] Push-Based Broker / Worker POC Protos#160james-mcnulty wants to merge 11 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
james-mcnulty
changed the title
…try/sentry-protos into george/push-broker-worker
|
|
||
| # Generated bindings | ||
| /py/sentry_protos/* | ||
| # /py/sentry_protos/* |
There was a problem hiding this comment.
This is just so I can use this repository instead of the official package when building Sentry for testing purposes. If I don't include the generated code it doesn't work, but it will be undone in the final version!
| @@ -0,0 +1,20 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package sentry_protos.taskworker.v1; | |||
There was a problem hiding this comment.
Could we keep these in the taskbroker.v1 package? It is likely that these protos will change alongside those ones.
| // If fetch_next is provided, receive a new task in the response | ||
| optional FetchNextTask fetch_next_task = 3; | ||
|
|
||
| string address = 4; |
There was a problem hiding this comment.
What kind of address is this? A comment could help here.
| @@ -0,0 +1 @@ | |||
| __version__ = "0.4.10" | |||
There was a problem hiding this comment.
Until this point we've not included python generated code in the repository. Instead we generate the python bindings when building a packaged release.
There was a problem hiding this comment.
Yepp, this is temporary so that I can use this repository as the source for the sentry-protos package in sentry.
| // If fetch_next is provided, receive a new task in the response | ||
| optional FetchNextTask fetch_next_task = 3; | ||
|
|
||
| string address = 4; |
There was a problem hiding this comment.
This should be optional if you're adding it to the existing version. Otherwise it might break services that aren't sending this address through.
There was a problem hiding this comment.
Got it. I think this is actually unnecessary, so it'll likely be gone in the final version anyways.
| // Update the state of a task with execution results. | ||
| rpc SetTaskStatus(SetTaskStatusRequest) returns (SetTaskStatusResponse) {} | ||
|
|
||
| // Add a worker to the broker's inner worker pool. |
There was a problem hiding this comment.
| // Add a worker to the broker's inner worker pool. | |
| // Register a worker as able to receive tasks from a broker. |
3 participants
See this PR.