feat(billing): Added trial, credit and constituent protos#184
Draft
krithikravi wants to merge 2 commits intomainfrom
Draft
feat(billing): Added trial, credit and constituent protos#184krithikravi wants to merge 2 commits intomainfrom
krithikravi wants to merge 2 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
krithikravi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the trial, credit and constituent protos, with the next step being constructing a trial service to populate a trial object, from the existing databases, similar to the contract service. Would appreciate feedback on the structure of the trial/credit proto, and possible missing fields: e.g is it okay to have just one status_changed_at field that stores first the activation time, then the cancellation/expiration time, or should we split it up into separate values? Are there any more tests you'd like to see? Additionally, how do you think this should be linked with a contract object - should we store a contract_id here, or have a Trial field in the contract? How are features accounted for here?