Skip to content

Conversation

@zsol
Copy link
Contributor

@zsol zsol commented Dec 16, 2025

Description

Same as #5206 but for the scripts/ and tests/ folder (plus there was one additional place in sentry_sdk that snuck in).

@zsol zsol marked this pull request as ready for review December 16, 2025 10:08
@zsol zsol requested a review from a team as a code owner December 16, 2025 10:08
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.15%. Comparing base (2ce4379) to head (4ccd7d2).
⚠️ Report is 24 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
- Coverage   84.25%   84.15%   -0.11%     
==========================================
  Files         181      182       +1     
  Lines       18463    18615     +152     
  Branches     3288     3318      +30     
==========================================
+ Hits        15556    15665     +109     
- Misses       1894     1931      +37     
- Partials     1013     1019       +6     
Files with missing lines Coverage Δ
sentry_sdk/integrations/mcp.py 79.47% <100.00%> (-3.64%) ⬇️

... and 15 files with indirect coverage changes

@alexander-alderman-webb
Copy link
Contributor

Thanks for the PR @zsol, it's nice to have one approach to typing in the repo!

We don't actually type check scripts/ or tests/ at the moment, but that's a problem for the future.

@alexander-alderman-webb alexander-alderman-webb merged commit e275c9e into getsentry:master Dec 16, 2025
164 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants