-
-
Notifications
You must be signed in to change notification settings - Fork 359
Cirrus Labs runners for other important workflows (where it makes sense to do so) + Ubuntu update (22.04 -> 24.04) #5696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4b40061
5d81a1f
2455944
058436c
9eeabcd
ff37e48
89602d5
acf3d9b
13d48a9
ac32ec9
05d1f4f
aaa3ffe
5d0d21a
ae49153
d49d024
40d1d22
171b87a
e1c20c3
f02d8d2
dbde591
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,12 +17,12 @@ jobs: | |
|
|
||
| job_test: | ||
| name: Test | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
@@ -36,12 +36,12 @@ jobs: | |
|
|
||
| job_lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
@@ -66,28 +66,49 @@ jobs: | |
| clang --version | ||
| clang-format --version | ||
|
|
||
| - name: Install Swiftly | ||
| - name: Install Swiftly and Swift | ||
| run: | | ||
| SWIFTLY_FILE="swiftly-$(uname -m).tar.gz" | ||
| curl -sL https://download.swift.org/swiftly/linux/swiftly-x86_64.tar.gz -o $SWIFTLY_FILE | ||
| tar zxf $SWIFTLY_FILE | ||
| # Install Swift dependencies first | ||
| sudo apt-get update | ||
| sudo apt-get -y install libcurl4-openssl-dev libz3-dev libncurses-dev libedit-dev libxml2-dev | ||
|
|
||
| ARCH=$(uname -m) | ||
| SWIFTLY_FILE="swiftly-${ARCH}.tar.gz" | ||
| curl -sL "https://download.swift.org/swiftly/linux/swiftly-${ARCH}.tar.gz" -o "$SWIFTLY_FILE" | ||
| tar zxf "$SWIFTLY_FILE" | ||
|
|
||
| ./swiftly init --quiet-shell-followup | ||
| . "${SWIFTLY_HOME_DIR:-$HOME/.local/share/swiftly}/env.sh" | ||
| hash -r | ||
| sudo apt-get -y install libcurl4-openssl-dev | ||
|
|
||
| # Install Swift 6.0 (compatible with SwiftLint 0.63.2) | ||
| swiftly install 6.0 | ||
| swift --version | ||
|
|
||
| # Export Swift toolchain path for SwiftLint's SourceKit | ||
| SWIFT_BIN=$(which swift) | ||
| SWIFT_TOOLCHAIN=$(dirname $(dirname "$SWIFT_BIN")) | ||
| SOURCEKIT_PATH=$(find "${SWIFT_TOOLCHAIN}" -name "libsourcekitdInProc.so" -print -quit 2>/dev/null) | ||
| if [ -n "$SOURCEKIT_PATH" ]; then | ||
| echo "LINUX_SOURCEKIT_LIB_PATH=$(dirname "$SOURCEKIT_PATH")" >> $GITHUB_ENV | ||
| else | ||
| echo "ERROR: libsourcekitdInProc.so not found under ${SWIFT_TOOLCHAIN}" | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Lint | ||
| run: yarn lint | ||
| run: | | ||
| . "${SWIFTLY_HOME_DIR:-$HOME/.local/share/swiftly}/env.sh" | ||
| yarn lint | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| job_check_integrity: | ||
| name: Check package integrity | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
@@ -106,12 +127,12 @@ jobs: | |
|
|
||
| job_build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
|
Comment on lines
+135
to
137
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The bash command in the Suggested FixCorrect the bash syntax in the Prompt for AI Agent |
||
| package-manager-cache: false | ||
|
|
@@ -148,14 +169,14 @@ jobs: | |
|
|
||
| job_type_check: | ||
| name: Type Check Typescript 3.8 | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [job_build, diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| env: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
@@ -181,12 +202,12 @@ jobs: | |
| run: yarn type-check | ||
| job_circular_dep_check: | ||
| name: Circular Dependency Check | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [job_build, diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
@@ -210,7 +231,7 @@ jobs: | |
|
|
||
| job_bundle: | ||
| name: Bundle | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| needs: [job_test, job_build, diff_check] | ||
| if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} | ||
| strategy: | ||
|
|
@@ -221,7 +242,7 @@ jobs: | |
| dev: [true, false] | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - run: npm i -g corepack | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 | ||
| with: | ||
| package-manager-cache: false | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ jobs: | |
| name: iOS | ||
| appPlain: performance-tests/test-app-plain.ipa | ||
| - platform: android | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:10"] | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
| name: Android | ||
| appPlain: performance-tests/TestAppPlain/android/app/build/outputs/apk/release/app-release.apk | ||
| steps: | ||
|
|
@@ -205,7 +205,7 @@ jobs: | |
| rn-version: '0.84.0' | ||
| runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2.0", "runner_group_id:10"] | ||
| - platform: android | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:10"] | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can also revert the Android e2e, sample and expo-sample runners back to GH Ubuntu like 8ddab36 and see how this goes. The Cirrus lab runners are way faster but we may end up being queued if more thing run on them.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say we can keep them for e2e since the benifit is pretty significant there but maybe use GH Ubuntu for sample and expo sample. what do you think, @antonis ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good @alwx ๐ |
||
| exclude: | ||
| # exclude JSC for new RN versions (keeping the matrix manageable) | ||
| - rn-version: '0.84.0' | ||
|
|
@@ -332,9 +332,9 @@ jobs: | |
| include: | ||
| - platform: ios | ||
| rn-version: '0.84.0' | ||
| runs-on: macos-26 | ||
| runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2.0", "runner_group_id:10"] | ||
| - platform: android | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:10"] | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:10"] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.