-
-
Notifications
You must be signed in to change notification settings - Fork 359
fix(android): replace tasks.findAll with tasks.named() to fix AGP Artifacts API conflict #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f2ac3b7
fix(android): replace tasks.findAll with tasks.named() to fix AGP Artโฆ
antonis 05a6b03
Adds changelog
antonis 0930fb9
fix(android): fix variant capitalization and task timing in sentry.grโฆ
antonis 469101e
fix(android): restore missing bundle task warning via taskGraph.whenRโฆ
antonis 34b4c82
fix(android): move bundle task lookup to afterEvaluate, restore warning
antonis 6e0c31b
fix(android): resolve AGP variant data inside onVariants, not afterEvโฆ
antonis 5b6b7c0
fix(android): remove afterEvaluate wrapper, fix indentation in sentryโฆ
antonis ccaff51
fix(android): pre-register sentry tasks in onVariants to fix Gradle 8.x
antonis 2b4333b
fix(android): use ctx map to avoid TaskProvider.configure inside confโฆ
antonis 513a738
test(android): add Gradle test-repro for task-realization regressions
antonis 3166b30
Revert "test(android): add Gradle test-repro for task-realization regโฆ
antonis 4f179d3
fix(android): replace tasks.findAll with tasks.named to fix AGP Artifโฆ
antonis 8ab52e9
fix(android): simplify variant capitalization using Groovy capitalize()
antonis 0783a58
Merge branch 'main' into antonis/issue-5698
antonis fb8fdc6
Merge branch 'main' into antonis/issue-5698
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theoretically we could use this named overload which accepts a string filter? It would return a TaskCollection which we could run a
forEachorconfigureEachon, preserving the previous behavior pretty much.But no strong preference, the current approach is also fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking at this @romtsn ๐
I think this is a good suggestion. I'll keep this PR as is for now since it has been tested to fix the issue and ship it with 8.2.0 later today. I'll iterate on the suggestion on a follow up PR.