feat(feedback): Show feedback widget on device shake by antonis · Pull Request #5729 · getsentry/sentry-react-native

antonis · 2026-02-26T15:24:00Z

Summary

Implements shake-to-report for the feedback widget (ref: #4735).

iOS: Detects shake via UIWindow.motionEnded:withEvent: (UIKit responder chain) — no permissions required (NSMotionUsageDescription is only needed for Core Motion/CMMotionManager, not UIKit shake events)
Android: Detects shake via SensorManager.TYPE_ACCELEROMETER — no permissions required (BODY_SENSORS permission is only needed for heart rate and similar body sensors)
JS: New showFeedbackOnShake() / hideFeedbackOnShake() imperative APIs + feedbackIntegration({ enableShakeToReport: true }) declarative option

Key design decisions

Zero external dependencies — all native shake detection uses platform built-in APIs
No permission prompts — both iOS and Android shake detection methods operate without any permission grants
iOS uses method swizzling on UIWindow (same approach as Instabug, Shake.io, etc.) with a boolean flag to enable/disable
Android uses accelerometer with a 2.7G threshold and 1s cooldown to prevent duplicate triggers
FeedbackWidgetProvider auto-starts shake detection when enableShakeToReport: true is set on the integration, and cleans up on unmount

New files

src/js/feedback/ShakeToReportBug.ts — JS shake event listener management
ios/RNSentryShakeDetector.h/m — iOS native shake detection
android/.../RNSentryShakeDetector.java — Android native shake detection
test/feedback/ShakeToReportBug.test.tsx — 9 tests covering unit + integration

Test plan

All 9 new shake tests pass
All 85 existing feedback tests pass (no regressions)
No new TypeScript errors
Manual test on iOS device/simulator
Manual test on Android device/emulator
Verify shake threshold feels natural on real devices

Closes #4735

🤖 Generated with Claude Code

github-actions · 2026-02-26T15:24:21Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

feat(feedback): Show feedback widget on device shake by antonis in #5729

chore(deps): update JavaScript SDK to v10.40.0 by github-actions in #5715
ci: Cancel in-progress CI jobs when a PR is closed or merged by antonis in #5725

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-02-26T15:24:39Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3cb51f5

CHANGELOG.md

Implement device shake detection to trigger the feedback widget. No permissions are required on either platform: - iOS: Uses UIKit's motionEnded:withEvent: via UIWindow swizzle - Android: Uses SensorManager accelerometer (TYPE_ACCELEROMETER) Public API: - showFeedbackOnShake() / hideFeedbackOnShake() imperative APIs - feedbackIntegration({ enableShakeToReport: true }) declarative option Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-02-26T17:02:04Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	415.77 ms	464.06 ms	48.29 ms
Size	43.75 MiB	48.48 MiB	4.73 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c7f264b`	434.98 ms	452.96 ms	17.98 ms
`9f211e3`	451.50 ms	500.00 ms	48.50 ms
`9ced351`+dirty	405.40 ms	419.39 ms	13.98 ms
`f70acbf`+dirty	373.39 ms	382.81 ms	9.43 ms
`f234eb4`+dirty	407.62 ms	429.64 ms	22.02 ms
`2adbd1e`+dirty	433.98 ms	427.96 ms	-6.02 ms
`7886639`+dirty	425.10 ms	477.73 ms	52.63 ms
`a206511`+dirty	424.28 ms	474.82 ms	50.54 ms
`98f632c`	424.25 ms	435.48 ms	11.23 ms
`46da307`	455.92 ms	443.79 ms	-12.13 ms

App size

Revision	Plain	With Sentry	Diff
`c7f264b`	17.75 MiB	19.68 MiB	1.94 MiB
`9f211e3`	17.75 MiB	19.68 MiB	1.94 MiB
`9ced351`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`f70acbf`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`f234eb4`+dirty	17.75 MiB	19.74 MiB	1.99 MiB
`2adbd1e`+dirty	17.75 MiB	19.70 MiB	1.96 MiB
`7886639`+dirty	43.75 MiB	48.42 MiB	4.67 MiB
`a206511`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`98f632c`	17.75 MiB	20.15 MiB	2.41 MiB
`46da307`	17.75 MiB	19.68 MiB	1.93 MiB

github-actions · 2026-02-26T17:09:16Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1201.12 ms	1211.18 ms	10.06 ms
Size	3.38 MiB	4.79 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-02-26T17:50:13Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1209.83 ms	1217.35 ms	7.51 ms
Size	3.38 MiB	4.79 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`bef3709`+dirty	1217.79 ms	1225.33 ms	7.54 ms
`a206511`+dirty	1225.02 ms	1223.74 ms	-1.28 ms
`74979ac`+dirty	1212.33 ms	1212.54 ms	0.21 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`8a868fe`+dirty	1206.85 ms	1215.04 ms	8.19 ms
`d590428`+dirty	1221.23 ms	1225.27 ms	4.03 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-02-26T18:17:01Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	377.25 ms	420.26 ms	43.01 ms
Size	43.94 MiB	49.34 MiB	5.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`664c66f`+dirty	376.23 ms	389.51 ms	13.28 ms
`d73150f`+dirty	424.60 ms	454.35 ms	29.75 ms
`4a17c8f`+dirty	368.54 ms	381.43 ms	12.89 ms
`b3b5b0d`+dirty	361.42 ms	403.90 ms	42.48 ms
`9ced351`+dirty	361.74 ms	411.45 ms	49.70 ms
`7886639`+dirty	530.30 ms	571.34 ms	41.04 ms
`c08359e`+dirty	406.04 ms	428.87 ms	22.83 ms
`3099014`+dirty	344.58 ms	404.21 ms	59.63 ms
`d751a5d`+dirty	341.61 ms	403.06 ms	61.45 ms
`682f0f5`+dirty	402.33 ms	440.61 ms	38.28 ms

App size

Revision	Plain	With Sentry	Diff
`664c66f`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`d73150f`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`4a17c8f`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`b3b5b0d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`9ced351`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`7886639`+dirty	43.94 MiB	49.28 MiB	5.34 MiB
`c08359e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`3099014`+dirty	7.15 MiB	8.43 MiB	1.27 MiB
`d751a5d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`682f0f5`+dirty	43.94 MiB	48.91 MiB	4.97 MiB

antonis commented Feb 26, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

antonis force-pushed the antonis/feedback-shake branch from 636498e to 9bc0c17 Compare February 26, 2026 15:57

antonis added 2 commits February 26, 2026 17:04

Add to sample app

c5d398e

Merge branch 'main' into antonis/feedback-shake

3cb51f5

antonis added the ready-to-merge Triggers the full CI test suite label Feb 26, 2026

Uh oh!

Conversation

antonis commented Feb 26, 2026

Summary

Key design decisions

New files

Test plan

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading