-
-
Notifications
You must be signed in to change notification settings - Fork 58
chore: Utilize app-runner for WebGL #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bitsandfoxes
wants to merge
82
commits into
main
Choose a base branch
from
feat/app-runner-webgl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
65bfb99
First iteration
bitsandfoxes d90e410
Fixes
bitsandfoxes 323d187
Remove startup awake span assertion
bitsandfoxes 5b30b7d
Fixed desktop test validation order
bitsandfoxes 20554a9
Fixed single-line pwsh command
bitsandfoxes b899cc5
strictmode workaround
bitsandfoxes 7c93e12
Baking the DSN
bitsandfoxes 3dceec0
.
bitsandfoxes e999f6e
Fix env
bitsandfoxes b6fc8a2
.
bitsandfoxes f39fb13
Fix double event capture
bitsandfoxes 3902b68
Fixed log grouping
bitsandfoxes 0638d92
Debug log level
bitsandfoxes f05f223
Fixing 'dist'
bitsandfoxes 160f355
fallback to activity
bitsandfoxes f5e1c10
Do some fake work
bitsandfoxes 10ba69c
Drop stripping level for older than 6
bitsandfoxes c2e1256
Fixed vulkan issues
bitsandfoxes a0318cf
Code generation settings and log output
bitsandfoxes aa815ff
AOT check
bitsandfoxes fc3c734
Bumped .NET to 'main'
bitsandfoxes ab6d14e
Mark crash-capture skipped tests as Skipped instead of silently passing
bitsandfoxes af19c5e
Extending the tests of scope sync to the crash tests
bitsandfoxes 9588ff9
Skip app context assertion for crash-capture on Android
bitsandfoxes 0ffce53
Improved on the crashed second run validation
bitsandfoxes 8be86be
Incremental fix
bitsandfoxes d6c5084
Activity detection instead of try-catch
bitsandfoxes bf353f6
Get built-time check back in
bitsandfoxes d0e10ea
feedback
bitsandfoxes 0cc6ab4
skip 'dist' for now
bitsandfoxes 641f5e1
Apply suggestion from @bitsandfoxes
bitsandfoxes 36943c3
Migrate iOS CI to use app-runner
bitsandfoxes 8322cbd
bump app-runner
bitsandfoxes 9cf1ec5
fixes
bitsandfoxes 7f03d3f
Fix iOS integration test configuration
bitsandfoxes 5915218
Timeout and retry
bitsandfoxes 0965ded
machine feedback
bitsandfoxes 0457ff8
Merge branch 'main' into feat/app-runner-ios
bitsandfoxes 5f18483
timeout tweaks
bitsandfoxes 5af6bdd
.
bitsandfoxes 0f34226
Merge branch 'main' into feat/app-runner-ios
bitsandfoxes 3d035ca
bumped app-runner
bitsandfoxes 5a96ca9
Scope app context crash-capture skip to iOS only
bitsandfoxes 8ce299c
Merge branch 'main' into feat/app-runner-ios
bitsandfoxes 8803de8
bumped app-runner
bitsandfoxes b24c02a
desktop building and running
bitsandfoxes fbd0106
symbol upload
bitsandfoxes 0c827ab
windows docker tweaks
bitsandfoxes 8713530
fix unboun variable
bitsandfoxes a69115d
muck around with docker
bitsandfoxes c444ba6
more windows docker fun
bitsandfoxes 7c78621
diagnostics
bitsandfoxes f9badd7
docker..
bitsandfoxes bcd7dff
unity path inside the container
bitsandfoxes b255005
pin win22, nographics
bitsandfoxes 86f5906
back to win25. unity 6.3?
bitsandfoxes a1644da
nographics duplication
bitsandfoxes c5b3d03
handle 'nopgraphics'
bitsandfoxes dda6bf8
restructured desktop
bitsandfoxes 29b84a8
remove windows docker
bitsandfoxes 336c1b6
.
bitsandfoxes 887c96b
stoptheslop
bitsandfoxes b533abf
routing log output to stdout
bitsandfoxes 923c1cf
upsi
bitsandfoxes f5ffb41
run the app directly
bitsandfoxes d741d70
crashtype
bitsandfoxes 6dff615
cleanup
bitsandfoxes cc11c6c
cleanup
bitsandfoxes dca01a5
merged *-run-* for desktop
bitsandfoxes d82cd1e
webgl
bitsandfoxes 6ff3b4b
os
bitsandfoxes 7a07b5d
Merge branch 'main' into chore/desktop-integration-test
bitsandfoxes 5e93b72
Merge branch 'chore/desktop-integration-test' into feat/app-runner-webgl
bitsandfoxes 3e8bf00
review
bitsandfoxes 28a6b5a
message parsing
bitsandfoxes f13af9c
log printing
bitsandfoxes be0c49a
spaces in paths
bitsandfoxes f38c140
fixed webbackgroundworker
bitsandfoxes cb7d0d1
trycatch
bitsandfoxes 6c0a10d
Merge branch 'main' into feat/app-runner-webgl
bitsandfoxes ba8ca92
third merge hickup
bitsandfoxes 747d68b
.
bitsandfoxes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: "IntegrationTest: Run WebGL" | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| unity-version: | ||
| required: true | ||
| type: string | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: pwsh | ||
|
|
||
| jobs: | ||
| run: | ||
| name: WebGL ${{ inputs.unity-version }} | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SENTRY_TEST_DSN: ${{ secrets.SENTRY_TEST_DSN }} | ||
| SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
|
|
||
| - name: Initialize app-runner submodule | ||
| run: git submodule update --init modules/app-runner | ||
| shell: bash | ||
|
|
||
| - name: Download test app artifact | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4 | ||
| with: | ||
| name: testapp-webgl-compiled-${{ inputs.unity-version }} | ||
|
|
||
| - name: Extract test app | ||
| run: tar -xvzf test-app-webgl.tar.gz | ||
|
|
||
| - name: Install Selenium | ||
| run: pip3 install --upgrade selenium | ||
| shell: bash | ||
|
|
||
| - name: Run Integration Tests | ||
| timeout-minutes: 20 | ||
| run: | | ||
| $env:SENTRY_WEBGL_BUILD_PATH = "samples/IntegrationTest/Build" | ||
| Invoke-Pester -Path test/IntegrationTest/Integration.Tests.WebGL.ps1 -CI | ||
|
|
||
| - name: Upload test results on failure | ||
| if: ${{ failure() }} | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: testapp-webgl-logs-${{ inputs.unity-version }} | ||
| path: | | ||
| test/IntegrationTest/results/ | ||
| retention-days: 14 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.