Conversation
…types `sentry.normalized_description` can be `null` from the backend. Update the `SpanResponseRaw` type to reflect this and add `?? ''` fallbacks at all call sites that pass it to components expecting a `string`.
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/views/insights/browser/resources/components/tables/resourceTable.tsx
Show resolved
Hide resolved
scttcper
approved these changes
Mar 9, 2026
gggritso
deleted the
georgegritsouk/dain-1290-sqlish-fails-to-parse-some-queries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry.normalized_descriptioncan benullfrom the backend, but theSpanResponseRawtype previously typed it asstring. This caused runtime errors when the value was null — most notably, the SQLish parser was being called withnullinput, causing a TypeError that was being captured as a Sentry error.This PR updates the type to correctly reflect that
sentry.normalized_descriptionis nullable, and adds?? ''fallbacks at all call sites that pass it to components expecting a non-nullstring.Fixes DAIN-1290