Skip to content

feat(seer): Add is_private field to repo definitions for code review#110190

Merged
vaind merged 2 commits intomasterfrom
vaind/feat/add-is-private-to-repo-definition
Mar 9, 2026
Merged

feat(seer): Add is_private field to repo definitions for code review#110190
vaind merged 2 commits intomasterfrom
vaind/feat/add-is-private-to-repo-definition

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Mar 9, 2026

Add is_private: bool | None = None to SeerRepoDefinition and SeerCodeReviewRepoDefinition models, and populate it from the GitHub webhook payload's repository.private field when building code review requests for Seer.

The field is extracted in _build_repo_definition which now receives the webhook event_payload through _common_codegen_request_payload. This avoids any extra GitHub API calls — the data is already present in every pull_request and issue_comment webhook.

For non-webhook flows (autofix, coding agents), the field defaults to None since the webhook payload isn't available in those contexts.

Seer PR https://github.com/getsentry/seer/pull/5165

Implements CW-986

Populate is_private from the GitHub webhook payload's repository.private
field when building repo definitions for Seer code review requests. The
field is set in _build_repo_definition, which receives the event payload
through _common_codegen_request_payload.

Also adds the optional is_private field to SeerRepoDefinition and
SeerCodeReviewRepoDefinition models (defaults to None).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 9, 2026
@vaind vaind requested a review from a team March 9, 2026 01:35
@vaind vaind marked this pull request as ready for review March 9, 2026 01:35
@vaind vaind requested a review from a team as a code owner March 9, 2026 01:35
Include repo privacy status in the tags emitted for code review
webhook events, matching the scm_repo_is_private tag added on the
Seer side in getsentry/seer#5165.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to add it to SeerRepoDefinition since it doesn't seem to be consumed anywhere but i don't see a reason not to either

@vaind vaind merged commit 16f56cd into master Mar 9, 2026
58 checks passed
@vaind vaind deleted the vaind/feat/add-is-private-to-repo-definition branch March 9, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants