feat(button): Busy spinner with absolute position#110202
Draft
feat(button): Busy spinner with absolute position#110202
Conversation
github-actions
bot
added
the
Scope: Frontend
natemoo-re
reviewed
Mar 9, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Conceptually approved! Didn't see any visual errors in the preview 🙌
Would love to see the button docs updated and another once-over on the aria states for the entire component.
| visibility="visible" | ||
| > | ||
| {({className}) => ( | ||
| <BusySpinner className={className} role="status" aria-label="Busy" /> |
Member
There was a problem hiding this comment.
My preference would be to set the button's aria-label to Submitting rather than the spinner.
Found some interesting a11y insights that seem relevant!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the 3rd attempt to land de-980 after two reverts. This approach does not change the button internal layout to avoid the large blast radius of the first two approaches.