fix(onboarding): Mobile style tweaks for SCM onboarding#115426
Open
jaydgoss wants to merge 6 commits into
Open
fix(onboarding): Mobile style tweaks for SCM onboarding#115426jaydgoss wants to merge 6 commits into
jaydgoss wants to merge 6 commits into
Conversation
Unify the SCM feature card into a single 4-column grid (icon, label, volume, switch) with the description spanning the lower row, so the volume tag and switch no longer overflow on narrow viewports. Drop the responsive gap override on the info cards grid for consistency.
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
changed the title
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.50% |
The "Continue without a repo" skip button on the SCM connect step pushed the action row to overflow on narrow viewports. Wrap the label in an ellipsis-truncating Text element and allow the surrounding flex and the button itself to shrink below their natural content size so the row stays within the viewport.
Tooltip wraps non-DOM children in an inline span, which baseline-aligns inside the grid cell and visually offsets the volume tag and switch from the icon and label. Swap the surrounding Container for a Flex with align center so the Tooltip wrapper is vertically centered within its cell.
Span the description across the full remaining grid width using `column="2 / -1"` so it fills the row beneath the label, volume, and switch instead of stopping at column 4.
jaydgoss
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 56ad4d1. Configure here.
…gle column Merge the volume tag and switch into a shared toggle cell so the grid drops from 4 columns to 3 and the description naturally spans beneath the label and toggle.
Text defaults to variant=primary which sets color from `tokens.content.primary`, overriding the transparent button's `tokens.interactive.transparent.neutral.content.primary`. Set `variant=inherit` so the label keeps the button's color across states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens up several SCM onboarding screens on narrow viewports: