ref: Inline getTitleFromLocation helper function#115441
Open
ryan953 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.50% |
ryan953
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
getTitleFromLocationhelper function and inlines its implementation at call sites. The function was a simple wrapper arounddecodeScalar(location.query?.[key])that added minimal value.Changes
getTitleFromLocationfromstatic/app/views/explore/contexts/pageParamsContext/title.tsx(entire file deleted)getTitleFromLocationfromstatic/app/views/explore/queryParams/savedQuery.tsdecodeScalarcall directly:useAnalytics.tsxuseSaveMultiQuery.tsxmetrics/content.tsxmetrics/hooks/useSaveMetricsMultiQuery.tsxmultiQueryMode/index.tsxreplays/list/replayQueryParamsProvider.tsxspans/spansQueryParams.tsxlogs/logsQueryParams.tsxAll call sites now use
decodeScalar(location.query?.[key])ordecodeScalar(location.query.title)directly, making the code more straightforward and reducing unnecessary indirection.Test Plan
Existing tests should continue to pass. This is a straightforward refactoring that doesn't change any behavior—it only removes a thin wrapper function.
https://claude.ai/code/session_01Ku9kxsErPUgdjanXCu9rh2