ref(explore): Inline and remove getIdFromLocation helper#115442
Open
ryan953 wants to merge 2 commits into
Open
ref(explore): Inline and remove getIdFromLocation helper#115442ryan953 wants to merge 2 commits into
ryan953 wants to merge 2 commits into
Conversation
The getIdFromLocation function was a trivial wrapper around decodeScalar that added indirection without value. Inline all 12 call sites and delete both definitions.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.50% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getIdFromLocationwith directdecodeScalarcallscontexts/pageParamsContext/id.tsx(simple version with hardcodedidkey)getIdFromLocationfromqueryParams/savedQuery.ts(key-based version)The function was a trivial one-line wrapper around
decodeScalar(location.query.id)ordecodeScalar(location.query?.[key])that added indirection without providing meaningful abstraction.