fix(seer): Preserve recommended sort order for unscored issues in night shift#115444
Open
trevor-e wants to merge 5 commits into
Open
fix(seer): Preserve recommended sort order for unscored issues in night shift#115444trevor-e wants to merge 5 commits into
trevor-e wants to merge 5 commits into
Conversation
…ht shift Previously, all candidates were re-ranked by a weighted fixability score, which collapsed unscored issues (null fixability) to 0.0 and disrupted the recommended sort order from Snuba. Now candidates are split into three buckets: 1. Scored above threshold (>= MEDIUM) — sorted by fixability, taken first 2. Unscored (null) — preserves original recommended sort order as backfill 3. Scored below threshold — dropped entirely (already evaluated, not actionable) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
The test_selects_candidates_and_skips_triggered test used a fixability score of 0.2, which now falls below the MEDIUM threshold and gets excluded. Bump to 0.5 so the test still exercises two-candidate selection. Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
The severity field was only consumed by the score property removed in the prior commit. times_seen is kept since it's still used in triage logging. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 715ad2c. Configure here.
Unscored issues (null fixability) were being presented to the triage agent as fixability=0.00, which the prompt describes as "not fixable". Now fixability is None for unscored issues, rendered as "not scored" in the triage prompt, and the prompt instructs the agent to treat them neutrally. Co-Authored-By: Claude <noreply@anthropic.com>
The previous commit skipped the metric entirely when fixability was None. Restore the original unknown-group-id guard and only omit the threshold_action attribute when the score is missing. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixability_score_strategypreviously re-ranked all candidates by a weighted fixability score, which collapsed unscored issues (null fixability) to 0.0 — effectively disrupting the recommended sort order from Snuba for issues that hadn't been scored yet.MEDIUM/ 0.40) — sorted by fixability, taken firstTest plan
TestFixabilityScoreStrategyto verify scored issues come first, unscored preserve order, and below-threshold issues are excluded