Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ replays: 0007_organizationmember_replay_access

seer: 0011_add_project_repository_fk_to_seer

sentry: 1089_drop_rulefirehistory
sentry: 1090_rm_triggered_incidents_alertruletrigger

social_auth: 0003_social_auth_json_field

Expand Down
4 changes: 0 additions & 4 deletions src/sentry/incidents/models/alert_rule.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
from sentry.db.models.manager.base import BaseManager
from sentry.db.models.manager.base_query_set import BaseQuerySet
from sentry.incidents.models.incident import IncidentTrigger
from sentry.models.organization import Organization
from sentry.models.organizationmember import OrganizationMember
from sentry.models.project import Project
Expand Down Expand Up @@ -305,9 +304,6 @@ class AlertRuleTrigger(Model):
threshold_type = models.SmallIntegerField(null=True)
alert_threshold = models.FloatField()
resolve_threshold = models.FloatField(null=True)
triggered_incidents = models.ManyToManyField(
"sentry.Incident", related_name="triggers", through=IncidentTrigger
)
date_added = models.DateTimeField(default=timezone.now)

objects: ClassVar[AlertRuleTriggerManager] = AlertRuleTriggerManager()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Generated by Django 5.2.14 on 2026-05-12 22:30


from sentry.new_migrations.migrations import CheckedMigration
from sentry.new_migrations.monkey.fields import SafeRemoveField
from sentry.new_migrations.monkey.state import DeletionAction


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "1089_drop_rulefirehistory"),
]

operations = [
SafeRemoveField(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I've never removed a m2m field before - I got a couple errors trying to either first set it to be nullable (which makes sense) or adding a db_constraint=False - lmk if there is something else I need to do here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the many-to-many is managed via a through table that has FKs to this table I think this is all you need to do. Probably for completeness you need to do the final deletion migration too, but I think it will be a no-op

model_name="alertruletrigger",
name="triggered_incidents",
deletion_action=DeletionAction.MOVE_TO_PENDING,
),
]
Loading