refactor(onboarding): replace deprecated useRouter with useLocation and useNavigate#115453
Open
cursor[bot] wants to merge 2 commits into
Open
refactor(onboarding): replace deprecated useRouter with useLocation and useNavigate#115453cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…te in platformOptionsControl
Replace the legacy useRouter() hook from react-router 3 shim with the modern
useLocation() and useNavigate() hooks:
- useUrlPlatformOptions: router.location → useLocation()
- PlatformOptionsControl: router.replace() → navigate({...}, {replace: true})
Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
With useLocation() instead of useRouter(), query values are properly typed as QueryParamValue<string> (string | string[] | null | undefined) instead of 'any'. Add typeof string guard and non-null assertion for proper type safety. Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
useRouter()hook (a react-router 3 shim) with the modernuseLocation()anduseNavigate()hooks inplatformOptionsControl.tsx.Changes
useUrlPlatformOptionshook: replaceduseRouter().locationwithuseLocation()directlyPlatformOptionsControlcomponent: replaceduseRouter().replace()withuseNavigate()+{replace: true}optiontypeof queryValue === 'string'guard) sinceuseLocation()returns properly typed query values (QueryParamValue<string>) instead ofanyThis is part of the ongoing effort to remove react-router 3 shim code tracked in the React Router cleanup Notion database.
Verification
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.