Skip to content

ref(skills): Standardize skill paths to Agent Skills spec#66

Open
szokeasaurusrex wants to merge 2 commits intomainfrom
szokeasaurusrex/remove-claude-root
Open

ref(skills): Standardize skill paths to Agent Skills spec#66
szokeasaurusrex wants to merge 2 commits intomainfrom
szokeasaurusrex/remove-claude-root

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Feb 24, 2026

Removes ${CLAUDE_SKILL_ROOT} usage and standardizes skill file references to scripts/..., references/..., and assets/... per the Agent Skills specification.

Why

${CLAUDE_SKILL_ROOT} was introduced in #37 to help with path confusion. In that PR, the skill definition defined what the variable meant. Later, that variable appears to have been copied throughout all skills in this repo, without the proper definition, which is a problem, because the variable is not part of the Agent Skills specification, nor is it recognized by Claude Code per its docs.

Changes

  • Replace ${CLAUDE_SKILL_ROOT}/... with skill-root-relative paths across affected skills, in compliance with the Agent Skills specification.
  • Update the wording in the iterate-pr and skill-scanner skills, so that we still clearly indicate that agents need to run the skills within the Git repo, but without relying on a non-standard variable that might start popping up elsewhere without a proper definition.
  • Update README.md and AGENTS.md path conventions.
  • Update skill-creator/scripts/quick_validate.py to error on ${CLAUDE_SKILL_ROOT}.

Removes `${CLAUDE_SKILL_ROOT}` usage and standardizes skill file references to `scripts/...`, `references/...`, and `assets/...` per the [Agent Skills specification](https://agentskills.io/specification).

Why:
- `${CLAUDE_SKILL_ROOT}` was introduced to address path confusion (PR #38 context).
- It was later copied across skills without consistently defining it.
- It is not part of the [Agent Skills specification](https://agentskills.io/specification).

Changes:
- Replace `${CLAUDE_SKILL_ROOT}/...` with skill-root-relative paths across affected skills.
- Keep iterate-pr's execution safety guidance (`run from repo root`; `invoke scripts using absolute paths`) while removing repeated variable usage.
- Update `README.md` and `AGENTS.md` path conventions.
- Update `skill-creator/scripts/quick_validate.py` to error on `${CLAUDE_SKILL_ROOT}`.

Risk: low (docs/guidance/validation only; script behavior unchanged).
Warden correctly pointed out the original wording is confusing
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review February 24, 2026 17:47
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I've never had issues with the skills defined in this repo, this seems legit.
A CLAUDE_SKILL_ROOT env var was never part of the Agent Skills spec.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


```bash
uv run ${CLAUDE_SKILL_ROOT}/scripts/fetch_pr_checks.py [--pr NUMBER]
uv run scripts/fetch_pr_checks.py [--pr NUMBER]

This comment was marked as off-topic.

### Phase 4: Prompt Injection Analysis

Load `${CLAUDE_SKILL_ROOT}/references/prompt-injection-patterns.md` for context.
Load `references/prompt-injection-patterns.md` for context.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants