feat(ci): Ensure self-hosted e2e tests run on PR's

[hubertdeng123]

self-hosted e2e tests were not run on PR's, and we needed to fix with #7466. This ensures it runs

[aldy505]

Can we only run this when it's ${{ github.event_name == 'pull_request' }}, and keep the one on image.yml file to test it with an actual pushed GHCR Docker image?

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Unnecessary files-changed dependency blocks job without benefit
  • Removed files-changed from the needs array of self-hosted-end-to-end since the job never references any of its outputs.

Or push these changes by commenting:

@cursor push 57cf6bf9d0

Preview (57cf6bf9d0)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -577,7 +577,7 @@
         devservices-version: ${{ steps.get-devservices-version.outputs.version }}
 
   self-hosted-end-to-end:
-    needs: [snuba-image, files-changed]
+    needs: [snuba-image]
     if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     timeout-minutes: 30

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[cursor]

Unnecessary files-changed dependency blocks job without benefit

Low Severity

The self-hosted-end-to-end job lists files-changed in its needs array but never references any of its outputs (like needs.files-changed.outputs.api_changes). Every other job in this workflow that depends on files-changed actually uses its outputs. This unnecessary dependency means a failure in the files-changed job would prevent the e2e tests from running, which conflicts with the stated PR goal of ensuring these tests run on PRs. Removing files-changed from needs would simplify the dependency graph and make the job more robust.