chore: Add support for metrics-exporter-dogstatsd#564
Conversation
This will enable usage of native distributions and will lower the number number of custom metrics that taskbroker creates as venuer aggregates won't be used anymore.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }; | ||
| MetricsConfig { | ||
| statsd_addr: *statsd_addr, | ||
| metrics_host: config.metrics_host.clone(), |
There was a problem hiding this comment.
Unconditional statsd resolution panics when using dogstatsd
Low Severity
MetricsConfig::from_config unconditionally resolves statsd_addr via to_socket_addrs() with .expect(), even when metrics_host is configured and statsd won't be used. If a deployment only intends to use dogstatsd and statsd_addr is set to an invalid or unresolvable value, the application will panic at startup despite statsd not being needed. The resolution of statsd_addr could be deferred or made conditional on metrics_host being empty.
There was a problem hiding this comment.
That's ok. If metrics_host works, I'll remove all the statsd_addr logic.
2 participants
This will enable usage of native distributions and will lower the number number of custom metrics that taskbroker creates as venuer aggregates won't be used anymore.