[RFC] haskell build recipe updates

[liontiger23]

Note

This is independent of Upgrade of Haskell stack

Summary

Switched all remaining haskell packages that did not use %haskell_* macros to use them.

However, this highlighted some issues with expressiveness of current macros.
I had to use cabal directly for following tasks:

• install build dependencies like alex, happy and hspec-discover,
  which runhaskell Setup.hs does not build due to issue
• build dependent libraries with specific flags, because runhaskell Setup.hs apparently
  only supports version bounds in --constraint and not setting flags as well
  (needed for pandoc build with --constraint="pandoc +embed_data_files")

Below are summaries for each package:

• ghcup
  • Update build recipe to use %haskell-* macros instead of raw cabal
    as discussed at ghcup: Add at v0.1.50.2 #6540 (comment)
  • Disable parallel build due to weird bug in cabal/ghc
  • Replace .cabal patch file with --constraint argument
  • Enable running tests by explicitly providing hspec-discover
• pandoc
  • Update build recipe to use %haskell-* macros instead of raw cabal
    as discussed at ghcup: Add at v0.1.50.2 #6540 (comment)
  • Switch to hackage source for pandoc-cli specifically instead of whole pandoc repo
• pandoc-crossref
  • Switch to hackage source for pandoc-crossref to avoid ugly hack with rm of cabal.project.freeze
• sv2v
  • Update build recipe to use %haskell-* macros instead of raw cabal
    as discussed at ghcup: Add at v0.1.50.2 #6540 (comment)
  • Tests are disabled because they require following dependencies
    • Icarus Verilog - for Verilog simulation
    • shUnit2 - test framework

Checklist

• Package was built and tested against unstable
• This change could gainfully be listed in the weekly sync notes once merged

[liontiger23]

@GZGavinZhao please take a look

I tried to switch remaining packages to %haskell_* macros, but in some places I did have to inline them.

I am thinking that we could introduce several more macros:

• %cabal_install_build_tool (or something along those lines) that would do something like this:

  cabal update
  cabal install $@
  for exe in "$@"; do
    cp "$HOME/.cabal/bin/$exe" "/usr/bin/$exe"
  done
  

  We can use it install build-only executables:
  • in ghcup to install hspec-discover

    %cabal_install_build_tool hspec-discover
    

  • in sv2v to install alex and happy

    %cabal_install_build_tool alex happy
    

• %cabal_build_dependencies and %haskell_configure_exe which are just outlined parts of existing
  %cabal_configure macro
  • %cabal_build_dependencies

    cabal update
    cabal build %JOBS% --only-dependencies --disable-tests -O2 --ghc-options="-H128m %JOBS%" "$@"
    

  • %haskell_configure_exe

    %haskell_configure --disable-executable-dynamic \
                       --package-db=$HOME/.cabal/store/ghc-$GHCV/package.db \
                       "$@"
    

  Then to solve passing flags to pandoc library we could do

  %cabal_build_dependencies --constraint="crypton-x509-store == 1.6.11" \
                            --constraint="pandoc +embed_data_files"
  %haskell_configure_exe
  

[liontiger23]

Could be %cabal_install_build_tool hspec-discover

[liontiger23]

Maybe we can also bundle this rm -rf somewhere into %haskell_install_exe or something like that?

[liontiger23]

Here %cabal_configure works because --constraint contains only version specification

[liontiger23]

This could be

%cabal_build_dependencies --constraint="crypton-x509-store == 1.6.11" \
                          --constraint="pandoc +embed_data_files"
%haskell_configure_exe

[liontiger23]

Could be %cabal_install_build_tool alex happy