Sdk 2242 digital identity share v2 by mehmet-yoti · Pull Request #415 · getyoti/yoti-python-sdk

mehmet-yoti · 2024-10-24T15:10:56Z

No description provided.

saurabh-yoti

To avoid the need for a JSON session config while creating Share v2 session, we need to implement additional builders for Share v2 - Policy, Extensions, Constraints, Wanted.

This is in line with Other SDKs that have added Digital Identity (Share v2) support. Please refer to them.

saurabh-yoti · 2024-11-14T16:04:42Z

examples/yoti_example_flask/templates/index.html

  </main>

-  <script src="https://www.yoti.com/share/client/"></script>
+  <script src="https://www.public.stg1.dmz.yoti.com/share/client"></script>


Please change back to the Prod URL.

saurabh-yoti · 2024-11-14T16:04:49Z

examples/yoti_example_flask/templates/dynamic-share.html

    </section>
  </main>
-  <script src="https://www.yoti.com/share/client/"></script>
+  <script src="https://connect.public.stg1.dmz.yoti.com/share/client/"></script>


Please change back to the Prod URL.

saurabh-yoti · 2024-11-14T16:28:32Z

yoti_python_sdk/dynamic_sharing_service/dynamic_scenario_builder.py



 class DynamicScenarioBuilder(object):
+    print("Hello, World!")


Remove the print statement.

saurabh-yoti · 2024-11-14T16:29:20Z

yoti_python_sdk/profile.py


        if profile_attributes:
            for field in profile_attributes:
+                # print("field %s" % field)


Remove the commented print statement.

saurabh-yoti · 2024-11-14T16:31:17Z

yoti_python_sdk/tests/test-key.pem

Please remove this key.

saurabh-yoti · 2024-11-14T16:41:01Z

examples/digitalidentity/app.py

+            "subject_id": "some_subject_id_string"
+        }, # Optional reference to a user ID
+        "notification": {
+            "url": "https://webhook.site/818dc66b-e18b-4767-92c5-47c7af21629c",


Might be better to change URL to https://example.com/webhook-url.

saurabh-yoti · 2024-11-14T16:43:56Z

examples/digitalidentity/templates/index.html

+                    domId: 'webshare-target',
+                    sdkId: '99525f08-afbb-4420-98b9-0717309f7fed',
+                    skinId: 'yoti',
+                    flow: 'INLINE_QR',


INLINE_QR is a legacy value. Please change that to INSTANT.

Copilot

Pull Request Overview

This PR implements a new Digital Identity Share v2 functionality for the Yoti Python SDK, adding support for creating and managing share sessions, QR codes, and receipts with encryption handling.

Adds new digital identity client with methods for session and QR code management
Implements receipt decryption and content parsing functionality
Updates activity details to use new identifier properties

Reviewed Changes

Copilot reviewed 44 out of 66 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
yoti_python_sdk/digital_identity/	New module containing client and result classes for share v2 functionality
yoti_python_sdk/tests/digital_identity/	Test files for the new digital identity functionality
yoti_python_sdk/tests/test_client.py	Updated to use new user_identifier and receipt_identifier properties
examples/digitalidentity/	Complete Flask example application demonstrating the new functionality
setup.py	Updated protobuf and coverage versions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T21:57:35Z

yoti_python_sdk/dynamic_sharing_service/dynamic_scenario_builder.py



 class DynamicScenarioBuilder(object):
+    print("Hello, World!")


Debug print statement should be removed from production code as it will execute when the class is defined.

Suggested change

print("Hello, World!")

Copilot · 2025-09-30T21:57:36Z

yoti_python_sdk/profile.py


        if profile_attributes:
            for field in profile_attributes:
+                # print("field %s" % field)


Commented-out debug print statement should be removed from production code.

Suggested change

# print("field %s" % field)

Copilot · 2025-09-30T21:57:36Z

yoti_python_sdk/tests/doc_scan/session/retrieve/test_get_session_result.py

        assert len(result.id_document_text_data_checks) == 1
        assert isinstance(result.id_document_text_data_checks[0], TextDataCheckResponse)


Duplicate assertion lines 105-106 should be removed as they are identical to lines 102-103.

Suggested change

assert len(result.id_document_text_data_checks) == 1

assert isinstance(result.id_document_text_data_checks[0], TextDataCheckResponse)

Copilot · 2025-09-30T21:57:36Z

yoti_python_sdk/activity_details.py

+    @property
+    @deprecated
+    def user_id(self):
+        return self.__remember_me_id
+


Duplicate property definition for 'user_id' will cause the second definition to override the first.

Suggested change

@property

@deprecated

def user_id(self):

return self.__remember_me_id

Copilot · 2025-09-30T21:57:37Z

yoti_python_sdk/activity_details.py

    @user_id.setter
    @deprecated
-    def user_id(self, value):
+    def user_identifier(self, value):


The setter is named 'user_identifier' but should be 'user_id' to match the property it's setting.

Suggested change

def user_identifier(self, value):

def user_id(self, value):

Copilot · 2025-09-30T21:57:37Z

examples/digitalidentity/templates/profile.html

+                                        <table>
+                                            {% for key, value in attribute.value.items() %}
+                                                <tr>
+                                                    <td>bb{{ key }}<br/>


The 'bb' prefix appears to be debugging text that should be removed from the template.

Suggested change

<td>bb{{ key }}<br/>

<td>{{ key }}<br/>

mehmet-yoti added 9 commits October 24, 2024 15:50

SDK-2267:updated refs

c556aef

SDK-2267:updated refs

f4368e3

SDK-2242 added, create session, qrcode, and retrive session,receipt

683a073

SDK-2242 removed local test protobuf

53cd367

SDK-2242 added missing files

171bb0c

Updated github actions

e92d211

Updated github actions

bd31f91

Updated github actions

2cd58c4

SDK-2242-removed-files

8a1ac33

mehmet-yoti requested a review from saurabh-yoti October 24, 2024 15:11

mehmet-yoti added 3 commits October 24, 2024 17:04

Updated referenced libraries

cc485cf

Updated referenced libraries

9a8008c

removed unneccessary folder

df96b8f

saurabh-yoti requested changes Nov 14, 2024

View reviewed changes

saurabh-yoti requested a review from Copilot September 30, 2025 21:56

Copilot AI reviewed Sep 30, 2025

View reviewed changes

		assert len(result.id_document_text_data_checks) == 1
		assert isinstance(result.id_document_text_data_checks[0], TextDataCheckResponse)

Conversation

mehmet-yoti commented Oct 24, 2024

Uh oh!

saurabh-yoti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

saurabh-yoti Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saurabh-yoti left a comment •

edited

Loading