ci: validate model naming convention#22680
Conversation
|
Hm, not sure we want this in the same workflow file as EditorConfig, if it's separate we could run it only for changes to model files. |
|
Hmm yeah but at the same time I don't want to create too many files for small workflows like this one. And btw, to save some precious CI running time, I'm actually thinking about doing the reverse: group more style-related workflows into a single run |
I would argue that if we group more checks into a single run, then more checks add almost no costs. The time it takes is more likely for preparing the CI (getting queued, pull commits, install deps) |
Sure, but they would have to all be steps within the same job, not separate jobs like here. Either way, I think EditorConfig is important enough to deserve to live alone. |
Overview
Enforce naming convention as discussed in #22004 (comment)
Example:
LLM_ARCH_ABC_DEF_V123llama_model_abc_def_v123src/models/abc-def-v123.cppRequirements