Skip to content

ci: validate model naming convention#22680

Open
ngxson wants to merge 1 commit intoggml-org:masterfrom
ngxson:xsn/validate_model_filename
Open

ci: validate model naming convention#22680
ngxson wants to merge 1 commit intoggml-org:masterfrom
ngxson:xsn/validate_model_filename

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented May 4, 2026

Overview

Enforce naming convention as discussed in #22004 (comment)

Example:

  • arch name: LLM_ARCH_ABC_DEF_V123
  • model class name: llama_model_abc_def_v123
  • file name: src/models/abc-def-v123.cpp

Requirements

@ngxson ngxson requested a review from a team as a code owner May 4, 2026 14:10
@ngxson ngxson requested a review from CISC May 4, 2026 14:11
@github-actions github-actions Bot added the devops improvements to build systems and github actions label May 4, 2026
@CISC
Copy link
Copy Markdown
Member

CISC commented May 4, 2026

Hm, not sure we want this in the same workflow file as EditorConfig, if it's separate we could run it only for changes to model files.

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented May 4, 2026

Hmm yeah but at the same time I don't want to create too many files for small workflows like this one.

And btw, to save some precious CI running time, I'm actually thinking about doing the reverse: group more style-related workflows into a single run

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented May 4, 2026

we could run it only for changes to model files.

I would argue that if we group more checks into a single run, then more checks add almost no costs. The time it takes is more likely for preparing the CI (getting queued, pull commits, install deps)

@CISC
Copy link
Copy Markdown
Member

CISC commented May 5, 2026

we could run it only for changes to model files.

I would argue that if we group more checks into a single run, then more checks add almost no costs. The time it takes is more likely for preparing the CI (getting queued, pull commits, install deps)

Sure, but they would have to all be steps within the same job, not separate jobs like here.

Either way, I think EditorConfig is important enough to deserve to live alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants