tests: add BF16 non-contig coverage for MUL_MAT permutations#22689
Open
ServeurpersoCom wants to merge 1 commit intoggml-org:masterfrom
Open
tests: add BF16 non-contig coverage for MUL_MAT permutations#22689ServeurpersoCom wants to merge 1 commit intoggml-org:masterfrom
ServeurpersoCom wants to merge 1 commit intoggml-org:masterfrom
Conversation
The MUL_MAT test loop iterates over base_types[] to generate non-contig
permutation cases (3 standard permutations across n in {1, 8, 16}).
BF16 is absent from base_types[], so these 9 cases were never generated
for BF16 even though every other type covered by base_types[] tests them.
Add the missing 9 cases explicitly: BF16 x F32, m=16, k=256, bs=[2,3],
permutations {0,2,1,3}, {0,1,3,2}, {0,3,2,1}, with n in {1, 8, 16}.
Suggested-by: @jeffbolznv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The MUL_MAT test loop iterates over base_types[] to generate non-contig permutation cases (3 standard permutations across n in {1, 8, 16}). BF16 is absent from base_types[], so these 9 cases were never generated for BF16 even though every other type covered by base_types[] tests them.
Add the missing 9 cases explicitly: BF16 x F32, m=16, k=256, bs=[2,3], permutations {0,2,1,3}, {0,1,3,2}, {0,3,2,1}, with n in {1, 8, 16}. All cases pass on Vulkan.
Verified independent of #22677: reverting that PR locally and rerunning the suite still shows 9 OK on these new cases, so the coverage exercises a path that was already correct (cpy bf16 -> bf16 materialization for non-contig matmul), distinct from the bf16 -> f32 cpy pipeline added in #22677.
This is a first pass. Other BF16 coverage gaps spotted while investigating, candidates for follow-up PRs:
Happy to attack each as separate PRs, or batch them depending on what you prefer.
Follow-up to #22677.
cc @jeffbolznv
Requirements