webui: Remove Google Favicons & Improve MCP Information logic & UI#22719
Merged
allozaur merged 6 commits intoggml-org:masterfrom May 6, 2026
Merged
webui: Remove Google Favicons & Improve MCP Information logic & UI#22719allozaur merged 6 commits intoggml-org:masterfrom
allozaur merged 6 commits intoggml-org:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the Google favicon dependency from the WebUI MCP experience, refactors how MCP server identity metadata is displayed, and tweaks some MCP/settings layout behavior. It fits into the webui MCP integration by changing both favicon resolution in the store layer and the shared UI used to render MCP server names/icons.
Changes:
- Replaced Google favicon generation with MCP-provided icons plus a root-domain favicon fallback helper.
- Introduced a reusable
McpServerIdentitycomponent and updated multiple MCP-related views to use it. - Adjusted MCP/settings/chat UI layout and text truncation behavior, including MCP servers page scrolling.
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tools/server/webui/src/lib/utils/url.ts |
Adds helper to derive a root domain for favicon fallback URLs. |
tools/server/webui/src/lib/utils/index.ts |
Re-exports updated utility surface and removes favicon exports. |
tools/server/webui/src/lib/utils/favicon.ts |
Deletes Google favicon helper. |
tools/server/webui/src/lib/utils/cors-proxy.ts |
Removes string helper for proxied URLs. |
tools/server/webui/src/lib/stores/mcp.svelte.ts |
Changes favicon selection/fallback logic and stops proxying icon URLs. |
tools/server/webui/src/lib/services/mcp.service.ts |
Preserves MCP icon theme metadata and removes a debug log. |
tools/server/webui/src/lib/enums/ui.ts |
Normalizes protocol enum values to protocol-only strings. |
tools/server/webui/src/lib/enums/files.ts |
Adds ICO MIME types. |
tools/server/webui/src/lib/constants/mcp.ts |
Allows ICO MIME types for MCP icons. |
tools/server/webui/src/lib/constants/index.ts |
Removes favicon constant export. |
tools/server/webui/src/lib/constants/favicon.ts |
Deletes Google favicon constants. |
tools/server/webui/src/lib/components/app/settings/SettingsMcpServers.svelte |
Adjusts scrolling/layout and lets cards resolve favicons internally. |
tools/server/webui/src/lib/components/app/settings/SettingsChat/SettingsChatToolsTab.svelte |
Swaps custom favicon rendering for shared MCP identity UI. |
tools/server/webui/src/lib/components/app/models/ModelsSelectorSheet.svelte |
Tweaks truncated text sizing class usage. |
tools/server/webui/src/lib/components/app/misc/TruncatedText.svelte |
Adds min-w-0 to improve truncation behavior. |
tools/server/webui/src/lib/components/app/mcp/McpServerIdentity.svelte |
New shared component for MCP icon/name/version/website rendering. |
tools/server/webui/src/lib/components/app/mcp/McpServerCard/McpServerCardHeader.svelte |
Replaces inline server identity markup with shared component. |
tools/server/webui/src/lib/components/app/mcp/McpServerCard/McpServerCard.svelte |
Moves favicon lookup into the card itself. |
tools/server/webui/src/lib/components/app/mcp/McpResourcesBrowser/McpResourcesBrowserServerItem.svelte |
Reuses shared MCP identity UI in resource browser. |
tools/server/webui/src/lib/components/app/mcp/index.ts |
Exports the new shared MCP identity component. |
tools/server/webui/src/lib/components/app/chat/ChatForm/ChatFormActions/ChatFormActionAdd/ChatFormActionAddMcpServersSubmenu.svelte |
Reuses shared MCP identity UI in the add-server submenu. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ServeurpersoCom
approved these changes
May 5, 2026
ggerganov
approved these changes
May 6, 2026
22a0a07 to
aac9061
Compare
ServeurpersoCom
approved these changes
May 6, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes the Google Favicons dependent logic for getting MCP Server favicons. Additionally refactors the way that we get and display the MCP Server's metadata + fixes the MCP Servers page scrolling issues.
Close #20371
Additional information
Requirements