Skip to content

Filter tools openai server task#22725

Open
sonic182 wants to merge 1 commit intoggml-org:masterfrom
sonic182:feature/gemma4_running
Open

Filter tools openai server task#22725
sonic182 wants to merge 1 commit intoggml-org:masterfrom
sonic182:feature/gemma4_running

Conversation

@sonic182
Copy link
Copy Markdown

@sonic182 sonic182 commented May 5, 2026

Overview

closes #22722

In issue, I describe the bug. The fix is to emit correct SSE events when tool calls in llama-server, for most openai clients

Additional information

Before (combined chunk):

{"index":0,"id":"...","type":"function","function":{"name":"query_agent","arguments":"{"}}

After (split into two chunks):

{"index":0,"id":"...","type":"function","function":{"name":"query_agent"}}
{"index":0,"function":{"arguments":"{"}}

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES — Claude Code was used to help identify the root cause and locate the fix.

@sonic182 sonic182 requested a review from a team as a code owner May 5, 2026 15:57
@ggml-gh-bot
Copy link
Copy Markdown

ggml-gh-bot Bot commented May 5, 2026

Hi @sonic182, thanks for your contribution!

Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:

  • AI-generated content: This project does not accept PRs, descriptions or commit messages that are fully or predominantly AI-generated. If you have used AI to assist you in writing code, please make sure to disclose that explicitly.

Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below.

@sonic182
Copy link
Copy Markdown
Author

sonic182 commented May 5, 2026

not predominant AI for pr description

@sonic182 sonic182 changed the title no filter tools openai server task Filter tools openai server task May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug:

1 participant