-
Notifications
You must be signed in to change notification settings - Fork 90
automatic dependancy management with conan #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomatenkuchen
wants to merge
2
commits into
ghaerr:master
Choose a base branch
from
tomatenkuchen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| AccessModifierOffset: -2 | ||
| AlignAfterOpenBracket: DontAlign | ||
| AlignConsecutiveAssignments: false | ||
| AlignConsecutiveDeclarations: false | ||
| AlignEscapedNewlines: Left | ||
| AlignOperands: true | ||
| AlignTrailingComments: false | ||
| AllowAllParametersOfDeclarationOnNextLine: false | ||
| AllowShortBlocksOnASingleLine: true | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowShortFunctionsOnASingleLine: All | ||
| AllowShortIfStatementsOnASingleLine: true | ||
| AllowShortLoopsOnASingleLine: true | ||
| AlwaysBreakAfterDefinitionReturnType: None | ||
| AlwaysBreakAfterReturnType: None | ||
| AlwaysBreakBeforeMultilineStrings: true | ||
| AlwaysBreakTemplateDeclarations: false | ||
| BinPackArguments: false | ||
| BinPackParameters: false | ||
| BraceWrapping: | ||
| AfterClass: true | ||
| AfterControlStatement: false | ||
| AfterEnum: false | ||
| AfterFunction: true | ||
| AfterNamespace: false | ||
| AfterObjCDeclaration: false | ||
| AfterStruct: true | ||
| AfterUnion: false | ||
| BeforeCatch: false | ||
| BeforeElse: false | ||
| IndentBraces: false | ||
| SplitEmptyFunction: false | ||
| SplitEmptyNamespace: true | ||
| SplitEmptyRecord: true | ||
| BreakAfterJavaFieldAnnotations: true | ||
| BreakBeforeBinaryOperators: NonAssignment | ||
| BreakBeforeBraces: Custom | ||
| BreakBeforeInheritanceComma: true | ||
| BreakBeforeTernaryOperators: true | ||
| BreakConstructorInitializers: BeforeColon | ||
| BreakConstructorInitializersBeforeComma: false | ||
| BreakStringLiterals: true | ||
| ColumnLimit: 0 | ||
| CommentPragmas: '^ IWYU pragma:' | ||
| CompactNamespaces: false | ||
| ConstructorInitializerAllOnOneLineOrOnePerLine: false | ||
| ConstructorInitializerIndentWidth: 2 | ||
| ContinuationIndentWidth: 2 | ||
| Cpp11BracedListStyle: false | ||
| DerivePointerAlignment: false | ||
| DisableFormat: false | ||
| ExperimentalAutoDetectBinPacking: true | ||
| FixNamespaceComments: true | ||
| ForEachMacros: | ||
| - foreach | ||
| - Q_FOREACH | ||
| - BOOST_FOREACH | ||
| IncludeCategories: | ||
| - Priority: 2 | ||
| Regex: ^"(llvm|llvm-c|clang|clang-c)/ | ||
| - Priority: 3 | ||
| Regex: ^(<|"(gtest|gmock|isl|json)/) | ||
| - Priority: 1 | ||
| Regex: .* | ||
| IncludeIsMainRegex: (Test)?$ | ||
| IndentCaseLabels: false | ||
| IndentWidth: 2 | ||
| IndentWrappedFunctionNames: true | ||
| JavaScriptQuotes: Leave | ||
| JavaScriptWrapImports: true | ||
| KeepEmptyLinesAtTheStartOfBlocks: true | ||
| Language: Cpp | ||
| MacroBlockBegin: '' | ||
| MacroBlockEnd: '' | ||
| MaxEmptyLinesToKeep: 2 | ||
| NamespaceIndentation: Inner | ||
| ObjCBlockIndentWidth: 7 | ||
| ObjCSpaceAfterProperty: true | ||
| ObjCSpaceBeforeProtocolList: false | ||
| PointerAlignment: Right | ||
| ReflowComments: true | ||
| SortIncludes: true | ||
| SortUsingDeclarations: false | ||
| SpaceAfterCStyleCast: false | ||
| SpaceAfterTemplateKeyword: false | ||
| SpaceBeforeAssignmentOperators: true | ||
| SpaceBeforeParens: ControlStatements | ||
| SpaceInEmptyParentheses: false | ||
| SpacesBeforeTrailingComments: 0 | ||
| SpacesInAngles: false | ||
| SpacesInCStyleCastParentheses: false | ||
| SpacesInContainerLiterals: true | ||
| SpacesInParentheses: false | ||
| SpacesInSquareBrackets: false | ||
| Standard: Cpp11 | ||
| TabWidth: 8 | ||
| UseTab: Never | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| Checks: '*,-fuchsia-*,-google-*,-zircon-*,-abseil-*,-modernize-use-trailing-return-type,-llvm*' | ||
| HeaderFilterRegex: '' | ||
| FormatStyle: file | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| build/ | ||
| .vscode/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,244 +1,23 @@ | ||
| PROJECT( antigrain ) | ||
| cmake_minimum_required(VERSION 3.13...3.19) | ||
|
|
||
| # additional are modified Find routines | ||
| SET ( CMAKE_MODULE_PATH "${antigrain_SOURCE_DIR}/bin" ) | ||
| project(antigrain | ||
| VERSION 2.6 | ||
| DESCRIPTION "subpixel picture resolution algorithms" | ||
| LANGUAGES CXX C | ||
| ) | ||
|
|
||
| CMAKE_MINIMUM_REQUIRED( VERSION 2.4.8 ) | ||
| option(USE_GPC "use of gpc lib. caution! non-commertial licence only!" OFF) | ||
|
|
||
| SET(AGG_MAJOR_VERSION 0 ) | ||
| SET(AGG_MINOR_VERSION 1 ) | ||
| SET(AGG_BUILD_VERSION 1 ) | ||
| # support conan package manager | ||
| include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) | ||
| conan_basic_setup(TARGETS) | ||
|
|
||
| SET( AGG_FLAGS "" ) | ||
| SET( AGG_INCLUDE_DIRS "" ) | ||
| SET( AGG_LIBRARY_DIRS "" ) | ||
| SET( AGG_LIBRARIES "" ) | ||
| # support for clang tidy | ||
| set(CMAKE_CXX_CLANG_TIDY clang-tidy) | ||
|
|
||
| SET (LIBRARY_OUTPUT_PATH ${antigrain_BINARY_DIR}/lib/ CACHE PATH "Single output directory for building all libraries." FORCE ) | ||
| SET( AGG_LIBRARY_DIRS lib ) | ||
| #SET (EXECUTABLE_OUTPUT_PATH ${antigrain_BINARY_DIR}/exe/ CACHE PATH "Single output directory for building all executables.") | ||
| #MARK_AS_ADVANCED(LIBRARY_OUTPUT_PATH EXECUTABLE_OUTPUT_PATH) | ||
|
|
||
| LINK_DIRECTORIES( ${antigrain_BINARY_DIR}/lib ) | ||
|
|
||
| OPTION( agg_USE_GPC "Use Gpc Boolean library" OFF) | ||
| OPTION( agg_USE_FREETYPE "Use Freetype library" OFF) | ||
| OPTION( agg_USE_EXPAT "Use Expat library" OFF) | ||
| OPTION( agg_USE_SDL_PLATFORM "Use SDL as platform" OFF) | ||
| OPTION( agg_USE_PACK "Package Agg" OFF) | ||
| OPTION( agg_USE_AGG2D "Agg 2D graphical context" OFF) | ||
| OPTION( agg_USE_DEBUG "For debug version" OFF) | ||
|
|
||
| IF( agg_USE_DEBUG ) | ||
| #SET( PFDEBUG "d" ) | ||
| SET( CMAKE_DEBUG_POSTFIX "d" ) | ||
| ENDIF( agg_USE_DEBUG ) | ||
|
|
||
| # for the moment this decides the platform code. | ||
| IF(WIN32) | ||
| ADD_DEFINITIONS( -D_MSWVC_ -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE ) | ||
| SET( WIN32GUI WIN32 ) | ||
| INCLUDE_DIRECTORIES( ${antigrain_SOURCE_DIR}/font_win32_tt ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} font_win32_tt ) | ||
| ENDIF(WIN32) | ||
|
|
||
| IF(UNIX) | ||
| ADD_DEFINITIONS( -D__UNIX__ ) | ||
| SET( WIN32GUI "" ) | ||
|
|
||
| FIND_PACKAGE(X11) | ||
| IF(X11_FOUND) | ||
| INCLUDE_DIRECTORIES(${X11_INCLUDE_DIRS}) | ||
| LINK_LIBRARIES(${X11_LIBRARIES}) | ||
| ENDIF(X11_FOUND) | ||
|
|
||
| ENDIF(UNIX) | ||
|
|
||
| # more specific set platform code part to use for different compilers/tool sets | ||
| IF ( ${CMAKE_GENERATOR} STREQUAL "MSYS Makefiles" ) | ||
| SET (CMAKE_CXX_FLAGS_RELEASE "-DNDEBUG" CACHE STRING | ||
| "Flags used by the compiler during release builds" FORCE) | ||
| SET (CMAKE_CX_FLAGS_RELEASE "-DNDEBUG" CACHE STRING | ||
| "Flags used by the compiler during release builds" FORCE) | ||
| ENDIF ( ${CMAKE_GENERATOR} STREQUAL "MSYS Makefiles" ) | ||
|
|
||
| IF ( ${CMAKE_GENERATOR} STREQUAL "MinGW Makefiles" ) | ||
|
|
||
| ENDIF ( ${CMAKE_GENERATOR} STREQUAL "MinGW Makefiles" ) | ||
|
|
||
| IF ( ${CMAKE_GENERATOR} STREQUAL "Unix Makefiles" ) | ||
| IF( CYGWIN OR MINGW ) | ||
| SET (CMAKE_CXX_FLAGS_RELEASE "-DNDEBUG" CACHE STRING | ||
| "Flags used by the compiler during release builds" FORCE) | ||
| SET (CMAKE_C_FLAGS_RELEASE "-DNDEBUG" CACHE STRING | ||
| "Flags used by the compiler during release builds" FORCE) | ||
| ENDIF( CYGWIN OR MINGW ) | ||
| ENDIF ( ${CMAKE_GENERATOR} STREQUAL "Unix Makefiles" ) | ||
|
|
||
| IF ( ${CMAKE_GENERATOR} MATCHES "Visual Studio.*" ) | ||
|
|
||
| ENDIF ( ${CMAKE_GENERATOR} MATCHES "Visual Studio.*" ) | ||
|
|
||
| IF ( ${CMAKE_GENERATOR} MATCHES "Borland Makefiles" ) | ||
|
|
||
| ENDIF ( ${CMAKE_GENERATOR} MATCHES "Borland Makefiles" ) | ||
|
|
||
| ################################################## | ||
| # Set all includes, flags, libraries, related to expat | ||
| ################################################## | ||
|
|
||
| IF( agg_USE_EXPAT ) | ||
|
|
||
| FIND_PACKAGE( EXPAT ) | ||
|
|
||
| IF(EXPAT_FOUND) | ||
| INCLUDE_DIRECTORIES(${EXPAT_INCLUDE_DIRS}) | ||
| LINK_LIBRARIES(${EXPAT_LIBRARIES}) | ||
| ELSE(EXPAT_FOUND) | ||
| MESSAGE(SEND_ERROR "expat not found") | ||
| ENDIF(EXPAT_FOUND) | ||
| ENDIF( agg_USE_EXPAT ) | ||
|
|
||
| ################################################## | ||
| # Set all includes, flags, libraries, related to freetype | ||
| ################################################## | ||
|
|
||
| IF( agg_USE_FREETYPE ) | ||
| FIND_PACKAGE( Freetype ) | ||
| IF( FREETYPE_FOUND ) | ||
| INCLUDE_DIRECTORIES( ${FREETYPE_INCLUDE_DIRS} ) | ||
| LINK_LIBRARIES( ${FREETYPE_LIBRARIES} ) | ||
| LINK_DIRECTORIES( ${FREETYPE_LINK_DIR} ) | ||
| ELSE( FREETYPE_FOUND ) | ||
| MESSAGE(SEND_ERROR "freetype not found") | ||
| ENDIF( FREETYPE_FOUND ) | ||
| ENDIF( agg_USE_FREETYPE ) | ||
|
|
||
| ################################################## | ||
| # Set all includes, flags, libraries, related to SDL | ||
| ################################################## | ||
|
|
||
| FIND_PACKAGE( SDL QUIET ) | ||
| IF( SDL_FOUND ) | ||
| IF ( agg_USE_SDL_PLATFORM ) | ||
| INCLUDE_DIRECTORIES(${SDL_INCLUDE_DIR}) | ||
| LINK_LIBRARIES(${SDL_LIBRARY}) | ||
| ENDIF ( agg_USE_SDL_PLATFORM ) | ||
| ELSE( SDL_FOUND ) | ||
| IF ( agg_USE_SDL_PLATFORM ) | ||
| MESSAGE( "SDL libray was not found, disable agg_USE_SDL_PLATFORM please" ) | ||
| ENDIF ( agg_USE_SDL_PLATFORM ) | ||
| ENDIF( SDL_FOUND ) | ||
|
|
||
| # the main include dir of Agg | ||
| INCLUDE_DIRECTORIES( ${antigrain_SOURCE_DIR}/include ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} include ) | ||
|
|
||
| # freetype specific lib of Agg | ||
| IF( agg_USE_FREETYPE ) | ||
| INCLUDE_DIRECTORIES( ${antigrain_SOURCE_DIR}/font_freetype ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} font_freetype ) | ||
| ADD_DEFINITIONS( -DAGG_USE_FREETYPE ) | ||
| SET( AGG_FLAGS ${AGG_FLAGS} -DAGG_USE_FREETYPE ) | ||
| LINK_LIBRARIES( freetypefont ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} aggfontfreetype${PFDEBUG} ) | ||
| ENDIF( agg_USE_FREETYPE ) | ||
|
|
||
| # GPC lib if used within Agg | ||
| IF ( agg_USE_GPC ) | ||
| INCLUDE_DIRECTORIES( ${antigrain_SOURCE_DIR}/gpc ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} gpc ) | ||
| ADD_DEFINITIONS( -DAGG_USE_GPC ) | ||
| SET( AGG_FLAGS ${AGG_FLAGS} -DAGG_USE_GPC ) | ||
| LINK_LIBRARIES( gpcbool ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} gpc${PFDEBUG} ) | ||
| ENDIF ( agg_USE_GPC ) | ||
|
|
||
| # agg2d lib if used within Agg | ||
| IF ( agg_USE_AGG2D ) | ||
| INCLUDE_DIRECTORIES( ${antigrain_SOURCE_DIR}/agg2d ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} agg2d ) | ||
| ADD_DEFINITIONS( -DAGG_USE_AGG2D ) | ||
| OPTION( agg_USE_AGG2D_FREETYPE "Agg 2D graphical context uses freetype" OFF) | ||
| SET( AGG_FLAGS ${AGG_FLAGS} -DAGG_USE_AGG2D ) | ||
| LINK_LIBRARIES( agg2d ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} agg2d${PFDEBUG} ) | ||
| ENDIF ( agg_USE_AGG2D ) | ||
|
|
||
| IF ( agg_USE_AGG2D_FREETYPE ) | ||
| ADD_DEFINITIONS( -DAGG2D_USE_FREETYPE ) | ||
| SET( AGG_FLAGS ${AGG_FLAGS} -DAGG2D_USE_FREETYPE ) | ||
| ENDIF ( agg_USE_AGG2D_FREETYPE ) | ||
|
|
||
| # sld as platform or os | ||
| IF( SDL_FOUND AND agg_USE_SDL_PLATFORM ) | ||
| LINK_LIBRARIES( controls sdlplatform antigrain ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} aggctrl${PFDEBUG} aggsdlplatform${PFDEBUG} agg${PFDEBUG} ) | ||
| ELSE( SDL_FOUND AND agg_USE_SDL_PLATFORM ) | ||
| LINK_LIBRARIES( controls platform antigrain ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} aggctrl${PFDEBUG} aggplatform${PFDEBUG} agg${PFDEBUG} ) | ||
| ENDIF( SDL_FOUND AND agg_USE_SDL_PLATFORM ) | ||
|
|
||
| SET( AGG_FLAGS ${AGG_FLAGS} CACHE STRING "Agg package flags" FORCE ) | ||
| SET( AGG_INCLUDE_DIRS ${AGG_INCLUDE_DIRS} CACHE STRING "Agg package libs include paths" FORCE ) | ||
| SET( AGG_LIBRARY_DIRS ${AGG_LIBRARY_DIRS} CACHE STRING "Agg package libs directory paths" FORCE ) | ||
| SET( AGG_LIBRARIES ${AGG_LIBRARIES} CACHE STRING "Agg package libraries" FORCE ) | ||
|
|
||
| ADD_SUBDIRECTORY( src ) | ||
|
|
||
| ADD_SUBDIRECTORY( examples ) | ||
|
|
||
| CONFIGURE_FILE( ${antigrain_SOURCE_DIR}/bin/AggConfig.cmake.in | ||
| ${antigrain_BINARY_DIR}/bin/AggConfig.cmake | ||
| @ONLY IMMEDIATE ) | ||
|
|
||
| CONFIGURE_FILE( ${antigrain_SOURCE_DIR}/bin/AggConfigOutBuild.cmake.in | ||
| ${antigrain_BINARY_DIR}/bin/AggConfigOutBuild.cmake | ||
| @ONLY IMMEDIATE ) | ||
|
|
||
| CONFIGURE_FILE( ${antigrain_SOURCE_DIR}/bin/FindAgg.cmake | ||
| ${antigrain_BINARY_DIR}/myapp/FindAgg.cmake | ||
| @ONLY IMMEDIATE ) | ||
|
|
||
| CONFIGURE_FILE( ${antigrain_SOURCE_DIR}/bin/UseAgg.cmake.in | ||
| ${antigrain_BINARY_DIR}/bin/UseAgg.cmake | ||
| @ONLY IMMEDIATE ) | ||
|
|
||
| ADD_SUBDIRECTORY( myapp ) | ||
|
|
||
| INSTALL( FILES ${antigrain_BINARY_DIR}/bin/AggConfigOutBuild.cmake DESTINATION "bin" RENAME AggConfig.cmake ) | ||
| INSTALL( FILES ${antigrain_BINARY_DIR}/bin/AggConfig.cmake DESTINATION "bin" ) | ||
| INSTALL( FILES ${antigrain_BINARY_DIR}/bin/UseAgg.cmake DESTINATION "bin" ) | ||
|
|
||
| #------------------------------------------------------------------- | ||
| # Build a CPack installer if CPack is available and this is a build | ||
| IF ( agg_USE_PACK ) | ||
| IF(EXISTS "${CMAKE_ROOT}/Modules/CPack.cmake") | ||
| SET(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Agg - Vector Graphics") | ||
| SET(CPACK_PACKAGE_VENDOR "Agg") | ||
| SET(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/copying") | ||
| SET(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/copying") | ||
| SET(CPACK_PACKAGE_VERSION_MAJOR "${AGG_MAJOR_VERSION}") | ||
| SET(CPACK_PACKAGE_VERSION_MINOR "${AGG_MINOR_VERSION}") | ||
| SET(CPACK_PACKAGE_VERSION_PATCH "${AGG_BUILD_VERSION}") | ||
| SET(CPACK_PACKAGE_INSTALL_DIRECTORY "AGG_${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}") | ||
| SET(CPACK_SOURCE_PACKAGE_FILE_NAME "agg-${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}") | ||
| SET(CPACK_PACKAGE_EXECUTABLES | ||
| "agg" "AGG" | ||
| ) | ||
| SET(CPACK_SOURCE_STRIP_FILES "") | ||
| SET(CPACK_STRIP_FILES "bin/ccmake;bin/cmake;bin/cpack;bin/ctest") | ||
|
|
||
|
|
||
| IF(WIN32) | ||
| SET(CPACK_NSIS_DISPLAY_NAME "${CPACK_PACKAGE_INSTALL_DIRECTORY}") | ||
| SET(CPACK_NSIS_HELP_LINK "http://agg.sourceforge.net") | ||
| SET(CPACK_NSIS_URL_INFO_ABOUT "http://agg.sourceforge.net") | ||
| SET(CPACK_NSIS_CONTACT "http://agg.sourceforge.net") | ||
| ENDIF(WIN32) | ||
|
|
||
| INCLUDE(CPack) | ||
| ENDIF(EXISTS "${CMAKE_ROOT}/Modules/CPack.cmake") | ||
| ENDIF ( agg_USE_PACK ) | ||
|
|
||
| INCLUDE( myapp/myproject.cmake ) | ||
| if(WIN32) | ||
| add_subdirectory(agg2d) | ||
| endif() | ||
| add_subdirectory(src) | ||
| add_subdirectory(examples) | ||
| add_subdirectory(myapp) | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like bad practice. We cannot compile without conan, conan should be used transparently