Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up the gsModule template repository structure by removing the legacy gsTemplates/ directory usage and consolidating template code under src/, aligning with how submodules are typically organized in this ecosystem.
Changes:
- Add
src/gsClass.has the new location for the template example class header. - Update the example to include the header from
<gsModule/gsClass.h>and remove the oldgsTemplates-based includes/usage. - Update
CMakeLists.txtto collect headers/sources/templates fromsrc/only (droppinggsTemplates/).
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/gsClass.h |
Introduces the example class header under src/ to replace the previous templates location. |
examples/helloSubmodule.cpp |
Updates includes and example usage to match the new header location. |
CMakeLists.txt |
Removes file collection from gsTemplates/ and consolidates collection to src/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gsModule is often used as a template repository, it should have a logical directory structure.
In my experience, the
gsTemplates/directory ingsModuledoes not fit the design of submodules. Instead, we usually go for putting everything insrc/.Therefore, this PR removes
gsTemplates/fromgsModule, aiming to force people to rely onsrcand making the template cleaner.