Skip to content

Use sapling-streampager instead of minus for paging#12421

Closed
Byron wants to merge 1 commit intomasterfrom
spike1
Closed

Use sapling-streampager instead of minus for paging#12421
Byron wants to merge 1 commit intomasterfrom
spike1

Conversation

@Byron
Copy link
Copy Markdown
Collaborator

@Byron Byron commented Feb 19, 2026 •
edited
Loading

This makes it possible to keep the visible content on screen, probably because it doesn't use an alaternate screen.

However, this still won't reprint the lines that are 'above' the screen.

Screen.Recording.2026-02-19.at.04.48.33.mov

Benefits of streampager over minus

  • It seems to be better with large content as it doesn't buffer everything, somehow.

Shortcomings of streampager over minus

  • It has more dependencies, and bundles fancy-regex

Tasks

  • repeat lines above the screen without duplicating content. This might need a patch in the streampager.
    • if we'd have to patch it, we might as well patch and vendor minus, which was unresponsive to my previous PR
    • maybe streampager, the original, would be more responsive to PRs
  • thorough testing - how does it work on Windows?
  • use the pager more, but validate how it interacts with input. Probably it's an opt-in affair anyway.
  • Thorough review and refactor (the PR is fully vibed

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 19, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
gitbutler-web Ignored Ignored Preview Feb 24, 2026 8:03am

Request Review

@github-actions github-actions Bot added rust Pull requests that update Rust code CLI The command-line program `but` labels Feb 19, 2026
@chatgpt-codex-connector @Byron
Use sapling-streampager instead of minus for paging
68e9c93 
This makes it possible to keep the visible content on screen,
probably because it doesn't use an alaternate screen.

However, this still won't reprint the lines that are
'above' the screen.

Also turn on paging for `status` now.
@Byron Byron closed this Apr 14, 2026
@Byron
Copy link
Copy Markdown
Collaborator Author

Byron commented Apr 14, 2026

A lot has changed (including priorities)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

CLI The command-line program `but` rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Byron