Numeric indexes for hunks (fileid:number)#12658
Merged
jonathantanmy2 merged 3 commits intomasterfrom Mar 2, 2026
Merged
Conversation
Each UncommittedFile will need access to its own hunks in a subsequent commit.
`fileid` can be any way to access a file (e.g. a filename or a short ID).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@krlvi we talked about this previously and I was worried about filenames with colons in them, but I think I found a solution (limit the number of colons to 2). I'm going to automerge this, but we can change things if you want. If this works, what do you think about removing the old autogenerated IDs (e.g.
g0) and using the colon IDs (e.g.kl:0) throughout?