Skip to content

Add PklProject filename to Pkl#7873

Open
nihaals wants to merge 1 commit intogithub-linguist:mainfrom
nihaals:pkl-project
Open

Add PklProject filename to Pkl#7873
nihaals wants to merge 1 commit intogithub-linguist:mainfrom
nihaals:pkl-project

Conversation

@nihaals
Copy link
Copy Markdown

@nihaals nihaals commented Mar 24, 2026

Add PklProject to Pkl's filenames.

Checklist:

@nihaals nihaals requested a review from a team as a code owner March 24, 2026 12:05
Copy link
Copy Markdown
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I have included a real-world usage sample for all extensions added in this PR:

You haven't. You need to actually add the files to the PR and also ensure the tests pass with the new filenames.

@nihaals
Copy link
Copy Markdown
Author

nihaals commented Mar 24, 2026

Oh it's referring to samples/ not just example links, will add them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants