Skip to content

Conversation

@henrymercer
Copy link
Contributor

To avoid issues with concurrency groups.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

To avoid issues with concurrency groups
@henrymercer henrymercer requested review from Copilot and mbg November 13, 2025 21:07
@henrymercer henrymercer requested a review from a team as a code owner November 13, 2025 21:07
@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the push trigger from manual check workflows (collection workflows) to avoid concurrency group issues. Collection workflows are meant to be triggered manually via workflow_dispatch and should not run automatically on push events.

Key Changes:

  • Updated the sync.py script to remove the push trigger from collection workflow generation
  • Regenerated the __go.yml workflow file to reflect the template change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pr-checks/sync.py Removed push trigger configuration from collection workflow template
.github/workflows/__go.yml Generated workflow file reflecting the template change (auto-generated, no review needed)

@henrymercer
Copy link
Contributor Author

henrymercer commented Nov 13, 2025

Never mind, this isn't sufficient. We may need to manually encode the name of the workflow in the concurrency group rather than using ${{ github.workflow }}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants