Use getDefaultCliVersion for start-proxy

[mbg]

Changes the start-proxy action to use getDefaultCliVersion rather than having defaults.bundleVersion hard-coded. Conveniently, this adds a permanent consumer of feature flags to start-proxy.

I have put this behind a new FF to gate the new behaviour to make this a less risky change.

Risk assessment

For internal use only. Please select the risk level of this change:

• Low risk

Which use cases does this change impact?

Workflow types:

• Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

• Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
• Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

• Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

• Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
• End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

• Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

• Telemetry - I rely on existing telemetry or have made changes to the telemetry.
  • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
  • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

• No special considerations - This change can be merged at any time.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Consider adding a changelog entry for this change.
• Confirm the readme and docs have been updated if necessary.

[Copilot]

Pull request overview

This pull request updates the start-proxy action to use getDefaultCliVersion from feature flags instead of hard-coding defaults.bundleVersion. This change allows the start-proxy action to dynamically determine the CodeQL CLI version to use, either from feature flags on GitHub.com or from defaults on GHES, making the behavior consistent with other actions in the codebase.

Changes:

• Modified getDownloadUrl and getProxyBinaryPath functions to accept a FeatureEnablement parameter
• Updated start-proxy-action.ts to initialize and pass feature flags to proxy-related functions
• Added comprehensive test coverage with proper feature flag mocking
• Removed unused Feature import from start-proxy-action.ts

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/start-proxy.ts	Updated function signatures to accept FeatureEnablement; changed to use getDefaultCliVersion for dynamic version selection; added getGitHubVersion import
src/start-proxy.test.ts	Updated test mocking to properly handle feature flags; added mockOfflineFeatures helper; modified tests to pass features parameter
src/start-proxy-action.ts	Removed unused Feature import; updated getProxyBinaryPath call to pass features parameter
lib/start-proxy-action.js	Generated JavaScript reflecting TypeScript changes

Comments suppressed due to low confidence (1)

src/start-proxy.ts:558

• The JSDoc comment for getProxyBinaryPath is missing documentation for the new features parameter. Please add a @param features entry to document this parameter.

/**
 * Gets a path to the proxy binary. If possible, this function will find the proxy in the
 * runner's tool cache. Otherwise, it downloads and extracts the proxy binary,
 * and stores it in the tool cache.
 *
 * @param logger The logger to use.
 * @returns The path to the proxy binary.
 */

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

[sam-robson]

Just a little nit, otherwise lgtm!

[sam-robson]

To save an API call, could we thread githubVersion through from

codeql-action/src/start-proxy-action.ts

Line 49 in bce0deb

const gitHubVersion = await getGitHubVersion();

?

[mbg]

We could thread it through, but getGitHubVersion should also cache the result from the API on the first call, so that the second call to getGitHubVersion here shouldn't result in an additional API call.

[sam-robson]

👍🏻 I see. Well I'll leave that as a judgment call to you, happy to approve.

[mbg]

Let's get this merged to unblock other PRs, thanks 👍🏻