Skip to content

Rust: Adopt shared flow summaries library #18130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 4 commits into from
Dec 3, 2024

Address review comments

52dc79e
Select commit
Loading
Failed to load commit list.
Merged

Rust: Adopt shared flow summaries library #18130

Address review comments
52dc79e
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Dec 3, 2024 in 9s

3 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 3 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 2 warnings
  • 6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 191 in rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Override with unmentioned parameter Warning

Override predicate doesn't mention
result
Loading
. Maybe mention it in a 'exists(result)'?

Check warning on line 755 in rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check notice on line 7 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 's' is not used.

Check notice on line 12 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.

Check notice on line 27 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 'e' is not used.

Check notice on line 40 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.

Check notice on line 59 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 'e' is not used.

Check notice on line 72 in rust/ql/test/library-tests/dataflow/models/main.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.