Skip to content

Rust: Additional test cases for tuple content. #21107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 2 commits into from
Jan 7, 2026
+112 −0
Merged

Rust: Additional test cases for tuple content. #21107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e2702c
Rust: Add some taint tests involving tuples.
geoffw0 Nov 28, 2025
13df236
Rust: Effect of lifting content reads as taint steps.
geoffw0 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions rust/ql/test/library-tests/dataflow/taint/TaintFlowStep.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,27 @@
| main.rs:72:24:72:27 | s[1] [pre-dereferenced] | main.rs:72:24:72:27 | s[1] |
| main.rs:77:9:77:12 | [post] arr2 [borrowed] | main.rs:77:9:77:12 | [post] arr2 |
| main.rs:77:9:77:15 | arr2[1] [pre-dereferenced] | main.rs:77:9:77:15 | arr2[1] |
| main.rs:98:14:98:47 | TupleExpr | main.rs:98:14:98:49 | ... .0 |
| main.rs:99:14:99:47 | TupleExpr | main.rs:99:14:99:49 | ... .1 |
| main.rs:102:14:102:28 | source_tuple(...) | main.rs:102:14:102:30 | ... .0 |
| main.rs:103:14:103:28 | source_tuple(...) | main.rs:103:14:103:30 | ... .1 |
| main.rs:106:14:106:83 | TupleExpr | main.rs:106:14:106:85 | ... .0 |
| main.rs:107:14:107:83 | TupleExpr | main.rs:107:14:107:85 | ... .0 |
| main.rs:107:14:107:85 | ... .0 | main.rs:107:14:107:87 | ... .0 |
| main.rs:108:14:108:83 | TupleExpr | main.rs:108:14:108:85 | ... .0 |
| main.rs:108:14:108:85 | ... .0 | main.rs:108:14:108:87 | ... .1 |
| main.rs:109:14:109:83 | TupleExpr | main.rs:109:14:109:85 | ... .1 |
| main.rs:110:14:110:83 | TupleExpr | main.rs:110:14:110:85 | ... .1 |
| main.rs:110:14:110:85 | ... .1 | main.rs:110:14:110:87 | ... .0 |
| main.rs:111:14:111:83 | TupleExpr | main.rs:111:14:111:85 | ... .1 |
| main.rs:111:14:111:85 | ... .1 | main.rs:111:14:111:87 | ... .1 |
| main.rs:114:14:114:64 | TupleExpr | main.rs:114:14:114:66 | ... .0 |
| main.rs:115:14:115:64 | TupleExpr | main.rs:115:14:115:66 | ... .0 |
| main.rs:115:14:115:66 | ... .0 | main.rs:115:14:115:68 | ... .0 |
| main.rs:116:14:116:64 | TupleExpr | main.rs:116:14:116:66 | ... .0 |
| main.rs:116:14:116:66 | ... .0 | main.rs:116:14:116:68 | ... .1 |
| main.rs:117:14:117:64 | TupleExpr | main.rs:117:14:117:66 | ... .1 |
| main.rs:118:14:118:64 | TupleExpr | main.rs:118:14:118:66 | ... .1 |
| main.rs:118:14:118:66 | ... .1 | main.rs:118:14:118:68 | ... .0 |
| main.rs:119:14:119:64 | TupleExpr | main.rs:119:14:119:66 | ... .1 |
| main.rs:119:14:119:66 | ... .1 | main.rs:119:14:119:68 | ... .1 |
48 changes: 48 additions & 0 deletions rust/ql/test/library-tests/dataflow/taint/inline-taint-flow.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ edges
| main.rs:62:14:62:16 | arr | main.rs:62:14:62:19 | arr[1] | provenance | MaD:6 |
| main.rs:77:9:77:12 | [post] arr2 [element] | main.rs:78:14:78:17 | arr2 | provenance | |
| main.rs:77:19:77:28 | source(...) | main.rs:77:9:77:12 | [post] arr2 [element] | provenance | |
| main.rs:98:14:98:47 | TupleExpr [tuple.0] | main.rs:98:14:98:49 | ... .0 | provenance | |
| main.rs:98:15:98:30 | source_string(...) | main.rs:98:14:98:47 | TupleExpr [tuple.0] | provenance | |
| main.rs:102:14:102:28 | source_tuple(...) | main.rs:102:14:102:30 | ... .0 | provenance | |
| main.rs:103:14:103:28 | source_tuple(...) | main.rs:103:14:103:30 | ... .1 | provenance | |
| main.rs:108:14:108:83 | TupleExpr [tuple.0, tuple.1] | main.rs:108:14:108:85 | ... .0 [tuple.1] | provenance | |
| main.rs:108:14:108:85 | ... .0 [tuple.1] | main.rs:108:14:108:87 | ... .1 | provenance | |
| main.rs:108:15:108:48 | TupleExpr [tuple.1] | main.rs:108:14:108:83 | TupleExpr [tuple.0, tuple.1] | provenance | |
| main.rs:108:32:108:47 | source_string(...) | main.rs:108:15:108:48 | TupleExpr [tuple.1] | provenance | |
| main.rs:114:14:114:64 | TupleExpr [tuple.0] | main.rs:114:14:114:66 | ... .0 | provenance | |
| main.rs:114:15:114:29 | source_tuple(...) | main.rs:114:14:114:64 | TupleExpr [tuple.0] | provenance | |
| main.rs:115:14:115:64 | TupleExpr [tuple.0] | main.rs:115:14:115:66 | ... .0 | provenance | |
| main.rs:115:14:115:66 | ... .0 | main.rs:115:14:115:68 | ... .0 | provenance | |
| main.rs:115:15:115:29 | source_tuple(...) | main.rs:115:14:115:64 | TupleExpr [tuple.0] | provenance | |
| main.rs:116:14:116:64 | TupleExpr [tuple.0] | main.rs:116:14:116:66 | ... .0 | provenance | |
| main.rs:116:14:116:66 | ... .0 | main.rs:116:14:116:68 | ... .1 | provenance | |
| main.rs:116:15:116:29 | source_tuple(...) | main.rs:116:14:116:64 | TupleExpr [tuple.0] | provenance | |
nodes
| main.rs:12:9:12:9 | a | semmle.label | a |
| main.rs:12:13:12:22 | source(...) | semmle.label | source(...) |
Expand Down Expand Up @@ -67,6 +83,30 @@ nodes
| main.rs:77:9:77:12 | [post] arr2 [element] | semmle.label | [post] arr2 [element] |
| main.rs:77:19:77:28 | source(...) | semmle.label | source(...) |
| main.rs:78:14:78:17 | arr2 | semmle.label | arr2 |
| main.rs:98:14:98:47 | TupleExpr [tuple.0] | semmle.label | TupleExpr [tuple.0] |
| main.rs:98:14:98:49 | ... .0 | semmle.label | ... .0 |
| main.rs:98:15:98:30 | source_string(...) | semmle.label | source_string(...) |
| main.rs:101:14:101:28 | source_tuple(...) | semmle.label | source_tuple(...) |
| main.rs:102:14:102:28 | source_tuple(...) | semmle.label | source_tuple(...) |
| main.rs:102:14:102:30 | ... .0 | semmle.label | ... .0 |
| main.rs:103:14:103:28 | source_tuple(...) | semmle.label | source_tuple(...) |
| main.rs:103:14:103:30 | ... .1 | semmle.label | ... .1 |
| main.rs:108:14:108:83 | TupleExpr [tuple.0, tuple.1] | semmle.label | TupleExpr [tuple.0, tuple.1] |
| main.rs:108:14:108:85 | ... .0 [tuple.1] | semmle.label | ... .0 [tuple.1] |
| main.rs:108:14:108:87 | ... .1 | semmle.label | ... .1 |
| main.rs:108:15:108:48 | TupleExpr [tuple.1] | semmle.label | TupleExpr [tuple.1] |
| main.rs:108:32:108:47 | source_string(...) | semmle.label | source_string(...) |
| main.rs:114:14:114:64 | TupleExpr [tuple.0] | semmle.label | TupleExpr [tuple.0] |
| main.rs:114:14:114:66 | ... .0 | semmle.label | ... .0 |
| main.rs:114:15:114:29 | source_tuple(...) | semmle.label | source_tuple(...) |
| main.rs:115:14:115:64 | TupleExpr [tuple.0] | semmle.label | TupleExpr [tuple.0] |
| main.rs:115:14:115:66 | ... .0 | semmle.label | ... .0 |
| main.rs:115:14:115:68 | ... .0 | semmle.label | ... .0 |
| main.rs:115:15:115:29 | source_tuple(...) | semmle.label | source_tuple(...) |
| main.rs:116:14:116:64 | TupleExpr [tuple.0] | semmle.label | TupleExpr [tuple.0] |
| main.rs:116:14:116:66 | ... .0 | semmle.label | ... .0 |
| main.rs:116:14:116:68 | ... .1 | semmle.label | ... .1 |
| main.rs:116:15:116:29 | source_tuple(...) | semmle.label | source_tuple(...) |
subpaths
testFailures
#select
Expand All @@ -78,3 +118,11 @@ testFailures
| main.rs:47:14:47:19 | sliced | main.rs:45:17:45:26 | source(...) | main.rs:47:14:47:19 | sliced | $@ | main.rs:45:17:45:26 | source(...) | source(...) |
| main.rs:62:14:62:19 | arr[1] | main.rs:61:19:61:28 | source(...) | main.rs:62:14:62:19 | arr[1] | $@ | main.rs:61:19:61:28 | source(...) | source(...) |
| main.rs:78:14:78:17 | arr2 | main.rs:77:19:77:28 | source(...) | main.rs:78:14:78:17 | arr2 | $@ | main.rs:77:19:77:28 | source(...) | source(...) |
| main.rs:98:14:98:49 | ... .0 | main.rs:98:15:98:30 | source_string(...) | main.rs:98:14:98:49 | ... .0 | $@ | main.rs:98:15:98:30 | source_string(...) | source_string(...) |
| main.rs:101:14:101:28 | source_tuple(...) | main.rs:101:14:101:28 | source_tuple(...) | main.rs:101:14:101:28 | source_tuple(...) | $@ | main.rs:101:14:101:28 | source_tuple(...) | source_tuple(...) |
| main.rs:102:14:102:30 | ... .0 | main.rs:102:14:102:28 | source_tuple(...) | main.rs:102:14:102:30 | ... .0 | $@ | main.rs:102:14:102:28 | source_tuple(...) | source_tuple(...) |
| main.rs:103:14:103:30 | ... .1 | main.rs:103:14:103:28 | source_tuple(...) | main.rs:103:14:103:30 | ... .1 | $@ | main.rs:103:14:103:28 | source_tuple(...) | source_tuple(...) |
| main.rs:108:14:108:87 | ... .1 | main.rs:108:32:108:47 | source_string(...) | main.rs:108:14:108:87 | ... .1 | $@ | main.rs:108:32:108:47 | source_string(...) | source_string(...) |
| main.rs:114:14:114:66 | ... .0 | main.rs:114:15:114:29 | source_tuple(...) | main.rs:114:14:114:66 | ... .0 | $@ | main.rs:114:15:114:29 | source_tuple(...) | source_tuple(...) |
| main.rs:115:14:115:68 | ... .0 | main.rs:115:15:115:29 | source_tuple(...) | main.rs:115:14:115:68 | ... .0 | $@ | main.rs:115:15:115:29 | source_tuple(...) | source_tuple(...) |
| main.rs:116:14:116:68 | ... .1 | main.rs:116:15:116:29 | source_tuple(...) | main.rs:116:14:116:68 | ... .1 | $@ | main.rs:116:15:116:29 | source_tuple(...) | source_tuple(...) |
40 changes: 40 additions & 0 deletions rust/ql/test/library-tests/dataflow/taint/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,51 @@ mod array_sink {

use string::*;

mod tuples {
fn source_string(i: i64) -> String {
"".to_string()
}

fn source_tuple(i: i64) -> (String, String) {
Copy link
Contributor

@paldepind paldepind Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this function the returned tuple, but not its elements, will be tainted. Hence the tests using this function relies on the taint steps added in #20879.

Copy link
Contributor Author

@geoffw0 geoffw0 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thats the intent. 👍

("".to_string(), "".to_string())
}

fn sink<T>(t: T) {
}

pub fn tuples() {
sink((source_string(1), "".to_string()));
sink((source_string(1), "".to_string()).0); // $ hasValueFlow=1
sink((source_string(1), "".to_string()).1);

sink(source_tuple(2)); // $ hasValueFlow=2
sink(source_tuple(2).0); // $ hasTaintFlow=2
sink(source_tuple(2).1); // $ hasTaintFlow=2

sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())));
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).0);
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).0.0);
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).0.1); // $ hasValueFlow=3
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).1);
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).1.0);
sink((("".to_string(), source_string(3)), ("".to_string(), "".to_string())).1.1);

sink((source_tuple(4), ("".to_string(), "".to_string())));
sink((source_tuple(4), ("".to_string(), "".to_string())).0); // $ hasValueFlow=4
sink((source_tuple(4), ("".to_string(), "".to_string())).0.0); // $ hasTaintFlow=4
sink((source_tuple(4), ("".to_string(), "".to_string())).0.1); // $ hasTaintFlow=4
sink((source_tuple(4), ("".to_string(), "".to_string())).1);
sink((source_tuple(4), ("".to_string(), "".to_string())).1.0);
sink((source_tuple(4), ("".to_string(), "".to_string())).1.1);
}
}

fn main() {
addition();
negation();
cast();
string_slice();
array_source::array_tainted();
array_sink::array_with_taint();
tuples::tuples();
}