-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Cache API verification results across CI runs #5042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fa0901c
Cache API verification results across CI runs
kenyonj ba1b294
Address review feedback on cache persistence
kenyonj 083835c
Merge branch 'main' into cache-api-results-across-runs
ahpook cd2fa52
Merge branch 'main' into cache-api-results-across-runs
ahpook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,4 @@ vendor | |
| .bundle | ||
| .idea | ||
| .tool-versions | ||
| .api-cache.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a cached entry has
value.nil?, it's stored asnilin the JSON (line 325), and when loaded back (line 289-290), it's correctly reconstructed asnil. However, if a repository truly doesn't exist (NotFound), the code storesnilin the cache (line 92 in NewOctokit#repository), but this is indistinguishable from rate-limited entries whererepos[item] = trueis stored (line 90). When saving the cache, a rate-limited entry withvalue = truewill be converted to{ "full_name" => "true" }(line 325), which may cause issues when loading sincetruedoesn't respond to.full_namecorrectly. Consider handling thetruesentinel value explicitly.This issue also appears on line 332 of the same file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added
next if value == truebefore serializing both repos and users entries, so rate-limit sentinel values are skipped and won't produce corrupted cache data like{ "full_name" => "true" }.