test: add --block-domains integration tests by Mossaka · Pull Request #1051 · github/gh-aw-firewall

Mossaka · 2026-02-25T20:12:25Z

Summary

Add blockDomains?: string[] option to AwfRunner test fixture in tests/fixtures/awf-runner.ts
Add --block-domains flag handling in both run() and runWithSudo() methods
Add 6 integration tests for the --block-domains deny-list feature in tests/integration/blocked-domains.test.ts

Test Coverage

Block specific subdomain while allowing parent domain (--allow-domains github.com --block-domains api.github.com)
Allow non-blocked subdomains when parent is allowed
Block takes precedence over allow (same domain in both lists)
Wildcard blocking patterns (--block-domains *.github.com)
Multiple blocked domains
Debug output shows blocked domains configuration

Test plan

TypeScript compiles cleanly
npm run lint passes (0 errors)
npm run build passes
Integration tests verified locally (3/6 passed, 3 failed due to Docker container conflicts from concurrent test runs - not related to test logic)

Closes #1041

🤖 Generated with Claude Code

Add blockDomains option to AwfRunner test fixture and integration tests for the --block-domains deny-list feature: - Block specific subdomain while allowing parent domain - Block takes precedence over allow - Wildcard blocking patterns (*.github.com) - Multiple blocked domains - Debug output verification Closes #1041 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-25T20:13:15Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	82.39%	82.54%	📈 +0.15%
Statements	82.32%	82.46%	📈 +0.14%
Functions	82.74%	82.74%	➡️ +0.00%
Branches	74.55%	74.65%	📈 +0.10%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/docker-manager.ts`	83.6% → 84.1% (+0.56%)	82.8% → 83.4% (+0.54%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-02-25T20:16:26Z

Go Build Test Results

Project	Download	Tests	Status
color	✅	1/1	PASS
env	✅	1/1	PASS
uuid	✅	1/1	PASS

Overall: ✅ PASS

Generated by Build Test Go for issue #1051

github-actions · 2026-02-25T20:16:28Z

C++ Build Test Results

Project	CMake	Build	Status
fmt	✅	✅	PASS
json	✅	✅	PASS

Overall: PASS 🎉

All C++ projects configured and built successfully with GCC 13.3.0.

Generated by Build Test C++ for issue #1051

github-actions · 2026-02-25T20:16:31Z

Smoke Test Results — PASS

✅ GitHub MCP: docs: add integration test coverage guide with gap analysis #1036 docs: add integration test coverage guide with gap analysis / feat: group --help flags by category, hide dev-only options #1035 feat: group --help flags by category, hide dev-only options
✅ Playwright: github.com title contains "GitHub"
✅ File write: smoke-test-claude-22414057544.txt created
✅ Bash verify: file read back successfully

💥 [THE END] — Illustrated by Smoke Claude for issue #1051

github-actions · 2026-02-25T20:16:38Z

Bun Build Test Results

Project	Install	Tests	Status
elysia	✅	1/1	PASS
hono	✅	1/1	PASS

Overall: ✅ PASS

Bun version: 1.3.9

Generated by Build Test Bun for issue #1051

github-actions · 2026-02-25T20:16:39Z

.NET Build Test Results

Project	Restore	Build	Run	Status
hello-world	✅	✅	✅	PASS
json-parse	✅	✅	✅	PASS

Overall: PASS

Run output

hello-world: Hello, World!

json-parse:

{
  "Name": "AWF Test",
  "Version": 1,
  "Success": true
}
Name: AWF Test, Success: True

Generated by Build Test .NET for issue #1051

github-actions · 2026-02-25T20:16:40Z

Deno Build Test Results

Project	Tests	Status
oak	1/1	✅ PASS
std	1/1	✅ PASS

Overall: ✅ PASS

Generated by Build Test Deno for issue #1051

github-actions · 2026-02-25T20:17:02Z

🦀 Rust Build Test Results

Project	Build	Tests	Status
fd	✅	1/1	PASS
zoxide	✅	1/1	PASS

Overall: ✅ PASS

Generated by Build Test Rust for issue #1051

github-actions · 2026-02-25T20:17:04Z

Node.js Build Test Results ✅

Project	Install	Tests	Status
clsx	✅	✅	PASS
execa	✅	✅	PASS
p-limit	✅	✅	PASS

Overall: PASS

Generated by Build Test Node.js for issue #1051

github-actions · 2026-02-25T20:17:05Z

Smoke Test Results (Copilot engine, run 22414057589)

Test	Result
GitHub MCP — last 2 merged PRs	✅ #1036 `docs: add integration test coverage guide with gap analysis`, #1035 `feat: group --help flags by category, hide dev-only options`
Playwright — github.com title contains "GitHub"	✅
File write `/tmp/gh-aw/agent/smoke-test-copilot-22414057589.txt`	✅
Bash `cat` verify	✅

Overall: PASS — @Mossaka (no assignees)

📰 BREAKING: Report filed by Smoke Copilot for issue #1051

Copilot

Pull request overview

This PR adds comprehensive integration test coverage for the --block-domains CLI flag, which implements a deny-list on top of the existing allow-list functionality. The tests verify that blocked domains take precedence over allowed domains, support wildcard patterns, and work correctly with multiple domains.

Changes:

Added blockDomains?: string[] option to AwfOptions interface in test fixture
Implemented --block-domains flag handling in both run() and runWithSudo() test helper methods
Added 6 integration tests covering blocking behavior, precedence rules, wildcards, and debug output

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/fixtures/awf-runner.ts	Added blockDomains option to AwfOptions interface and implemented flag handling in both run() and runWithSudo() methods
tests/integration/blocked-domains.test.ts	Added new test suite "Block Domains Deny-List (--block-domains)" with 6 integration tests covering subdomain blocking, precedence, wildcards, multiple domains, and debug output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T20:17:09Z

tests/integration/blocked-domains.test.ts

+  test('should handle multiple blocked domains', async () => {
+    const result = await runner.runWithSudo(
+      'bash -c "curl -f --max-time 10 https://api.github.com/zen 2>&1; echo exit=$?"',
+      {
+        allowDomains: ['github.com'],
+        blockDomains: ['api.github.com', 'raw.githubusercontent.com'],
+        logLevel: 'debug',
+        timeout: 60000,
+      }
+    );
+    expect(result.stdout).toContain('exit=');
+    expect(result.stdout).not.toContain('exit=0');
+  }, 120000);


The test verifies that multiple blocked domains can be configured, but only tests that one domain (api.github.com) is actually blocked. Consider testing both blocked domains to ensure the configuration works correctly for all entries. For example, you could use a bash command that tries to curl both api.github.com and raw.githubusercontent.com and verifies that both fail.

Fixed in 85e27f7. Updated the test to curl both api.github.com and raw.githubusercontent.com, and added githubusercontent.com to allowDomains so the blocklist (not the allowlist) is what causes the failures.

github-actions · 2026-02-25T20:17:13Z

Merged PRs: docs: add integration test coverage guide with gap analysis; feat: group --help flags by category, hide dev-only options

GitHub MCP merged PRs ✅
safeinputs-gh pr list ✅
Playwright title ✅
Tavily search ❌ (tool missing)
File write ✅
Cat verify ✅
Discussion comment ✅
Build ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex for issue #1051

github-actions · 2026-02-25T20:18:28Z

Java Build Test Results

Project	Compile	Tests	Status
gson	✅	1/1	PASS
caffeine	✅	1/1	PASS

Overall: PASS ✅

Generated by Build Test Java for issue #1051

Address Copilot review: test both api.github.com and raw.githubusercontent.com are blocked, and add githubusercontent.com to allowDomains so the blocklist (not the allowlist) is what blocks them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-25T21:08:15Z

Deno Build Test Results

Project	Tests	Status
oak	1/1	✅ PASS
std	1/1	✅ PASS

Overall: ✅ PASS

Generated by Build Test Deno for issue #1051

github-actions · 2026-02-25T21:08:17Z

Go Build Test Results

Project	Download	Tests	Status
color	✅	PASS	✅ PASS
env	✅	PASS	✅ PASS
uuid	✅	PASS	✅ PASS

Overall: ✅ PASS

Generated by Build Test Go for issue #1051

github-actions · 2026-02-25T21:08:23Z

Build Test: Bun Results

Project	Install	Tests	Status
elysia	✅	1/1	PASS
hono	✅	1/1	PASS

Overall: ✅ PASS

Tested with Bun v1.3.9.

Generated by Build Test Bun for issue #1051

github-actions · 2026-02-25T21:08:31Z

.NET Build Test Results

Project	Restore	Build	Run	Status
hello-world	✅	✅	✅	PASS
json-parse	✅	✅	✅	PASS

Overall: PASS

Run output

hello-world: Hello, World!

json-parse:

{
  "Name": "AWF Test",
  "Version": 1,
  "Success": true
}
Name: AWF Test, Success: True

Generated by Build Test .NET for issue #1051

github-actions · 2026-02-25T21:08:36Z

C++ Build Test Results

Project	CMake	Build	Status
fmt	✅	✅	PASS
json	✅	✅	PASS

Overall: PASS

Generated by Build Test C++ for issue #1051

github-actions · 2026-02-25T21:08:59Z

🦀 Rust Build Test Results

Project	Build	Tests	Status
fd	✅	1/1	PASS
zoxide	✅	1/1	PASS

Overall: ✅ PASS

Generated by Build Test Rust for issue #1051

github-actions · 2026-02-25T21:09:14Z

Smoke Test Results — claude-sonnet-4-6

Test	Result
GitHub MCP (last 2 merged PRs: #1036 "docs: add integration test coverage guide...", #1035 "chore: remove smoke-gemini workflow")	✅
Playwright (github.com title contains "GitHub")	✅
File write (`smoke-test-claude-22415859966.txt`)	✅
Bash verify (cat file)	✅

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude for issue #1051

github-actions · 2026-02-25T21:09:28Z

GitHub MCP (last 2 merged PRs): ✅
docs: add integration test coverage guide with gap analysis
feat: group --help flags by category, hide dev-only options
safeinputs-gh pr list: ✅
Remove --allow-full-filesystem-access flag
feat: add API proxy port 10004 for OpenCode engine
Playwright title check: ✅
Tavily search: ❌ (tool unavailable)
File write + cat: ✅
Discussion comment: ✅
Build (npm ci && npm run build): ✅
Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex for issue #1051

github-actions · 2026-02-25T21:09:35Z

🤖 Smoke test results for PR #1051 (@Mossaka):

✅ GitHub MCP — Last 2 merged PRs: #1036 "docs: add integration test coverage guide with gap analysis", #1035 "feat: group --help flags by category, hide dev-only options"
✅ Playwright — github.com title contains "GitHub"
✅ File write — /tmp/gh-aw/agent/smoke-test-copilot-22415860001.txt created
✅ Bash verify — file read back successfully

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot for issue #1051

github-actions · 2026-02-25T21:09:35Z

🟢 Node.js Build Test Results

Project	Install	Tests	Status
clsx	✅	All passed	✅ PASS
execa	✅	All passed	✅ PASS
p-limit	✅	All passed	✅ PASS

Overall: ✅ PASS

Generated by Build Test Node.js for issue #1051

github-actions · 2026-02-25T21:10:15Z

☕ Java Build Test Results

Project	Compile	Tests	Status
gson	✅	1/1	PASS
caffeine	✅	1/1	PASS

Overall: ✅ PASS

All Java projects compiled and passed their tests successfully via Maven with the AWF proxy.

Generated by Build Test Java for issue #1051

Copilot AI review requested due to automatic review settings February 25, 2026 20:12

Copilot started reviewing on behalf of Mossaka February 25, 2026 20:12 View session

github-actions bot added build-test-cpp build-test-go labels Feb 25, 2026

github-actions bot added smoke-claude build-test-bun labels Feb 25, 2026

github-actions bot added the build-test-dotnet label Feb 25, 2026

github-actions bot added the build-test-deno label Feb 25, 2026

github-actions bot mentioned this pull request Feb 25, 2026

[agentics] No-Op Runs #769

Open

github-actions bot added the build-test-rust label Feb 25, 2026

github-actions bot added build-test-node smoke-copilot labels Feb 25, 2026

Copilot AI reviewed Feb 25, 2026

View reviewed changes

github-actions bot added the build-test-java label Feb 25, 2026

Mossaka merged commit 3715802 into main Feb 25, 2026
84 checks passed

Mossaka deleted the test/block-domains-tests branch February 25, 2026 22:45

Conversation

Mossaka commented Feb 25, 2026

Summary

Test Coverage

Test plan

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions bot commented Feb 25, 2026

Go Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

C++ Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Bun Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

.NET Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Deno Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

🦀 Rust Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Node.js Build Test Results ✅

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Mossaka Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Java Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Deno Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Go Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Build Test: Bun Results

Uh oh!

github-actions bot commented Feb 25, 2026

.NET Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

C++ Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

🦀 Rust Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

🟢 Node.js Build Test Results

Uh oh!

github-actions bot commented Feb 25, 2026

github-actions bot commented Feb 25, 2026 •

edited

Loading