Skip to content

Fix SEC-003 false positives in safe-outputs conformance check #17790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 23, 2026
+7 −2
Merged

Fix SEC-003 false positives in safe-outputs conformance check #17790

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fde4497
Initial plan
Copilot Feb 22, 2026
31251e0
fix(sec-003): scope check to octokit files and add missing enforcemen…
Copilot Feb 22, 2026
38fcbf1
fix(sec-003): also skip test files in max limits check
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/check-safe-outputs-conformance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,13 @@ check_max_limits() {
# Skip test and utility files
[[ "$handler" =~ (test|parse|buffer|factory) ]] && continue

# Check if handler enforces max limits
if ! grep -q "\.length.*>.*\.max\|enforceMaxLimit\|checkLimit\|max.*exceeded" "$handler"; then
# Only check files that perform GitHub API operations
if ! grep -q "octokit\." "$handler"; then
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern octokit. does not match the actual GitHub API usage pattern in this codebase. Handler files use github.rest. and github.graphql (where github is a global variable from @actions/github-script), not octokit.. This means the scope filter will match zero files, causing SEC-003 to report a false pass even though it's not checking any handlers. The same issue exists in SEC-002 (line 90). The pattern should be changed to match actual API calls, such as github\.rest\.|github\.graphql or simply \.rest\.|\.graphql.

This issue also appears on line 120 of the same file.

Copilot uses AI. Check for mistakes.
continue
fi

# Check if handler enforces max limits using any recognized pattern
if ! grep -qE "\.length.*>.*\.max|enforceMaxLimit|checkLimit|max.*exceeded|enforceArrayLimit|tryEnforceArrayLimit|limit_enforcement_helpers" "$handler"; then
log_medium "SEC-003: $handler may not enforce max limits"
failed=1
fi
Expand Down