Add storage.googleapis.com to node ecosystem#17944
Conversation
Multiple language ecosystems (Go, Dart, Deno) need access to storage.googleapis.com for package downloads and browser automation (Chrome for Testing). Adding it to the node ecosystem ensures Deno/Bun workflows can access it without needing the go or dart ecosystems. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
There was a problem hiding this comment.
Pull request overview
Adds storage.googleapis.com to the node ecosystem allowlist so Node/Bun/Deno workflows can access GCS-hosted assets (e.g., Chrome for Testing downloads) without cross-ecosystem configuration.
Changes:
- Added
storage.googleapis.comto thenodeecosystem domain list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Smoke Test: Copilot - 22315455866
Overall:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed PR #17944 — adds storage.googleapis.com to the Node ecosystem domains list. The change is minimal and correctly placed. No concerns.
📰 BREAKING: Report filed by Smoke Copilot
| "esm.sh", | ||
| "googleapis.deno.dev", | ||
| "googlechromelabs.github.io", | ||
| "storage.googleapis.com", |
There was a problem hiding this comment.
Good addition — storage.googleapis.com is needed for Node ecosystem workflows that download packages from Google Cloud Storage. The placement within the deno-cdns list looks correct.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
PR titles: [slides] Update AI Engines slide to include Gemini CLI; fix: stabilize compiled lock file output ordering
|
|
Commit pushed: |
Smoke Test Results — Run §22315455890Core Tests #1–10: ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅
Overall: PARTIAL — all non-skipped tests passed. Label
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal! Smoke test run 22315455890 verified this PR's changes look correct. The addition of storage.googleapis.com to the node ecosystem domains is appropriate and well-placed.
💥 [THE END] — Illustrated by Smoke Claude
2 participants
Summary
Add
storage.googleapis.comto thenodeecosystem domain list.Why
Deno and Bun workflows use the
nodeecosystem. Several repos (deno/fresh, deno/postgres) needstorage.googleapis.comfor:Currently it's only in the
goanddartecosystems, requiring awkward cross-ecosystem additions.Test plan
make test-unitpasses🤖 Generated with Claude Code
✨ PR Review Safe Output Test - Run 22315455890