Fix gh pr checkout failing with GH_HOST mismatch in issue_comment workflows

[Copilot]

When the DIFC proxy is active, start_difc_proxy.sh sets GH_HOST=localhost:18443 in GITHUB_ENV. The Checkout PR branch step runs before stop_difc_proxy.sh, so gh pr checkout fails because GH_HOST=localhost:18443 doesn't match any git remote (origin points to github.com or a GHE host).

Changes

• checkout_pr_branch.cjs: Derive GH_HOST from GITHUB_SERVER_URL and pass it as an explicit env override when invoking gh pr checkout, bypassing any stale or proxy-overridden value:

  const serverUrl = process.env.GITHUB_SERVER_URL || "https://github.com";
  const ghHost = serverUrl.replace(/^https?:\/\/|\/+$/g, "");
  await exec.exec("gh", ["pr", "checkout", prNumber.toString()], {
    env: { ...process.env, GH_HOST: ghHost },
  });

  Covers all cases: github.com, GHES (myorg.ghe.com), and DIFC proxy active (overrides localhost:18443).

• checkout_pr_branch.test.cjs: Updated all gh pr checkout call expectations to assert the env override is present; added GITHUB_SERVER_URL to beforeEach/afterEach; added 4 new tests covering DIFC proxy override, GHES host, protocol stripping, and missing-env fallback.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• invalid.example.invalid
  • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� user.name lure tions/setup/js/node_modules/.bin/git -M main /usr/sbin/git git init�� --bare --initial-branch=main k/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/git '/tmp/bare-incregit '/tmp/bare-increadd cal/bin/git git (dns block)
  • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git comm�� -m lure test commit k/node_modules/.bin/git -b main ode-gyp-bin/git git conf�� user.email test@test.com /git -b feature-branch it git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[github-actions]

Hey @Copilot 👋 — great work fixing the gh pr checkout GH_HOST mismatch with the DIFC proxy! This is a well-crafted bug fix that follows all the right patterns.

The change is tightly scoped to checkout_pr_branch.cjs and its test counterpart, the root cause is clearly explained in both the PR body and inline comments, and the fix is correct: deriving GH_HOST from the reliable GITHUB_SERVER_URL env var rather than letting a stale proxy-set value leak through. The test suite is thorough — 4 new dedicated test cases plus updated expectations across existing tests covering issue_comment, pull_request_target, GHES, DIFC proxy override, and missing-env fallback.

This PR looks ready for maintainer review. 🚀

Generated by Contribution Check · ● 2.6M · ◷