[WIP] Fix code based on review comments from pull request 26357#26365
Closed
[WIP] Fix code based on review comments from pull request 26357#26365
Conversation
- Remove GH_HOST, GITHUB_API_URL, GITHUB_GRAPHQL_URL, NODE_EXTRA_CA_CERTS, GH_AW_ORIGINAL_* writes from start_difc_proxy.sh - Remove all GITHUB_ENV restore/clear logic from stop_difc_proxy.sh - Add injectProxyEnvIntoCustomSteps() in compiler_difc_proxy.go that uses YAML parse+reserialize to add proxy env vars as step-level env on each custom step (preserving existing env vars like GH_TOKEN) - Remove generateSetGHRepoAfterDIFCProxyStep() standalone step; GH_REPO is now included in the per-step env block - Inject proxy env into custom steps in compiler_yaml_main_job.go when hasDIFCProxyNeeded returns true - Update tests: replace TestBuildSetGHRepoStepYAML/TestGenerateSetGHRepo with TestProxyEnvVars/TestInjectProxyEnvIntoCustomSteps; update TestDIFCProxyStepOrderInCompiledWorkflow for new behavior - Recompile 4 affected workflow lock files Agent-Logs-Url: https://github.com/github/gh-aw/sessions/c3114091-8d7b-4283-8647-91185fd5eb60 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
… proxy Generated by the Design Decision Gate workflow (run #24431428234). The PR makes >100 new lines of changes to pkg/workflow/ without a linked ADR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…for-review-comments Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…omments and use ordered fields Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4e545256-bb6a-4606-be79-362d0f6dcd96 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…ProxyEnvIntoCustomSteps Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4e545256-bb6a-4606-be79-362d0f6dcd96 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…env injection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…comments-review-26357 # Conflicts: # .github/workflows/contribution-check.lock.yml # .github/workflows/daily-issues-report.lock.yml # .github/workflows/issue-arborist.lock.yml # .github/workflows/stale-repo-identifier.lock.yml # actions/setup/sh/start_difc_proxy.sh # actions/setup/sh/stop_difc_proxy.sh # cmd/gh-aw/main.go # docs/src/content/docs/reference/playwright.md # pkg/cli/compile_compiler_setup.go # pkg/cli/compile_safe_update_integration_test.go # pkg/cli/upgrade_command.go # pkg/workflow/compiler.go # pkg/workflow/compiler_difc_proxy.go # pkg/workflow/compiler_difc_proxy_test.go # pkg/workflow/compiler_types.go # pkg/workflow/compiler_yaml.go # pkg/workflow/compiler_yaml_main_job.go # pkg/workflow/safe_update_enforcement.go # pkg/workflow/safe_update_enforcement_test.go Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…cedence Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2838a321-831b-4c1b-b298-2aacc15cb869 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.