Skip to content

Add zh_hant in opensource friday and rename zh to zh_hans#1322

Closed
jyangchisyan wants to merge 4 commits into
github:mainfrom
jyangchisyan:add_zh_hant
Closed

Add zh_hant in opensource friday and rename zh to zh_hans#1322
jyangchisyan wants to merge 4 commits into
github:mainfrom
jyangchisyan:add_zh_hant

Conversation

@jyangchisyan
Copy link
Copy Markdown

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Add zh_hant in opensource friday and rename zh to zh_hans

@jyangchisyan jyangchisyan requested a review from a team as a code owner December 30, 2025 03:21
@jyangchisyan jyangchisyan deleted the add_zh_hant branch December 31, 2025 03:00
@jyangchisyan jyangchisyan restored the add_zh_hant branch December 31, 2025 03:01
@jyangchisyan jyangchisyan reopened this Dec 31, 2025
@tomthorogood tomthorogood enabled auto-merge March 6, 2026 17:11
@tomthorogood tomthorogood disabled auto-merge March 6, 2026 17:12
@tomthorogood
Copy link
Copy Markdown
Contributor

closing/reopening to try and force codeql to run again

@tomthorogood tomthorogood reopened this Mar 6, 2026
@AndreaGriffiths11
Copy link
Copy Markdown
Contributor

Hey @jyangchisyan — thanks for opening #1322 and for the patience while this sat. The actual blocker turned out to be infrastructure, not your code: this repo's org-level code-scanning ruleset requires CodeQL results on every PR, but CodeQL default setup here only runs on pushes to main, not on fork PRs. So #1322 was permanently BLOCKED regardless of @tomthorogood's approval back in December.

To get it un-stuck I re-opened your change from a local branch in this repo as #1333 (you're preserved as the commit author). On top of your commit it picks up two small additions to address Copilot's review of the new PR:

redirect_from: /zh/ on the three zh_hans pages so existing inbound links (search results, external references) don't 404 after the rename.
Optional hreflang: field per locale + a tiny _includes/head.html change, so the alternate language links emit valid BCP 47 tags (zh-Hans / zh-Hant) instead of the underscore form. Every other locale is unchanged.
Closing this in favor of #1333. Really appreciate the contribution

AndreaGriffiths11 added a commit that referenced this pull request May 31, 2026
Add zh_hant, rename zh to zh_hans (re-opened from #1322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants