Skip to content

Potential fixes for 2 code scanning alerts #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cinderellasecure wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

Potential fixes for 2 code scanning alerts #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec66204
Potential fix for code scanning alert no. 2: Workflow does not contai…
cinderellasecure Nov 3, 2025
6716629
Potential fix for code scanning alert no. 1: Workflow does not contai…
cinderellasecure Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:

jobs:
publish-npm:
permissions:
contents: read
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish-npm job likely requires contents: write permission to publish packages or create releases, not just contents: read. Additionally, it may need id-token: write for npm provenance if using trusted publishing. Verify the required permissions match the job's actual operations.

Suggested change
contents: read
contents: write

Copilot uses AI. Check for mistakes.
Copy link

@jibrang jibrang Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if we should follow copilot recommendation here to use contents write instead of read.

Copy link
Author

@cinderellasecure cinderellasecure Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jibrang I will suggest using the copilot recommendation. Thanks

Copy link
Author

@cinderellasecure cinderellasecure Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot recommendation is preferred.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: Node CI
permissions:
contents: read

on: [push]

Expand Down