fix: Align native skills frontmatter with install_ai_skills#1920
fix: Align native skills frontmatter with install_ai_skills#1920RbBtSn0w wants to merge 2 commits intogithub:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces “skills drift” by documenting that there are multiple SKILL.md generators in spec-kit and aligning the native (release-packaged) SKILL.md frontmatter shape with the schema used by init-time conversion and extension/preset overrides.
Changes:
- Document (in code comments) that SKILL.md can be generated via template packaging,
install_ai_skills(), and extension/preset overrides, and that frontmatter keys must remain aligned. - Update release packaging scripts to include
compatibilityandmetadata(incl.metadata.source) in generated SKILL.md frontmatter. - Update AGENTS.md to reflect Codex’s
.agents/skills/convention and invocation pattern.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/agents.py |
Adds a technical-debt note clarifying multi-generator SKILL.md drift risk and schema alignment needs. |
src/specify_cli/__init__.py |
Documents the three SKILL.md generation paths and the minimum frontmatter schema to keep aligned. |
AGENTS.md |
Updates Codex directory convention to .agents/skills/ and clarifies skills invocation. |
.github/workflows/scripts/create-release-packages.sh |
Aligns native SKILL.md frontmatter by adding compatibility and metadata fields. |
.github/workflows/scripts/create-release-packages.ps1 |
Mirrors the shell script’s SKILL.md frontmatter updates in the PowerShell packaging script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mnriem
left a comment
There was a problem hiding this comment.
Please address Copilot feedback. If not applicable, please explain why
|
Addressed Copilot CR feedback:
Local verification:
|
|
@mnriem Copilot inline suggestions have been addressed and tests pass locally; could you please take another look? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow-up to #1906.
Context
SKILL.mdfiles.install_ai_skills()conversion, and extension overrides). If their frontmatter contracts drift, we end up with inconsistent skills across agents.What this PR changes
SKILL.mdincludes the same minimal frontmatter contract used byinstall_ai_skills()/ extension overrides (addscompatibilityandmetadata.{author,source}) and adds a short note to keep generators in sync.AGENTS.mdto reflect Codex’s.agents/skills/layout.NATIVE_SKILLS_AGENTSandrender_skill_command().Impact
install_ai_skills()conversion behavior.Related discussions
Test plan
bash -n .github/workflows/scripts/create-release-packages.sh