Refactor: Store EvaluatorLogPaths object on LocalQueryInfo #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the fields from EvaluatorLogPaths were copied 1:1 into LocalQueryInfo but under different names. It seems easier to keep track of the different kinds of logs if they are called the same everywhere.
koesie10
reviewed
Nov 18, 2024
Comment on lines
203
to
209
| public evalutorLogPaths: EvaluatorLogPaths = { | ||
| log: undefined, | ||
| humanReadableSummary: undefined, | ||
| endSummary: undefined, | ||
| jsonSummary: undefined, | ||
| summarySymbols: undefined, | ||
| }, |
Member
There was a problem hiding this comment.
Could this be undefined by default instead? That would make the change for making log | undefined unnecessary as well.
Comment on lines
35
to
41
| { | ||
| log: localQuery.evalLogLocation, | ||
| humanReadableSummary: localQuery.evalLogSummaryLocation, | ||
| jsonSummary: localQuery.jsonEvalLogSummaryLocation, | ||
| summarySymbols: localQuery.evalLogSummarySymbolsLocation, | ||
| endSummary: undefined, | ||
| }, |
Member
There was a problem hiding this comment.
Can we set this to undefined instead when the evalLogLocation is undefined?
koesie10
reviewed
Nov 20, 2024
| public evalLogSummaryLocation?: string, | ||
| public jsonEvalLogSummaryLocation?: string, | ||
| public evalLogSummarySymbolsLocation?: string, | ||
| public evalutorLogPaths?: EvaluatorLogPaths, |
Member
There was a problem hiding this comment.
Suggested change
| public evalutorLogPaths?: EvaluatorLogPaths, | |
| public evaluatorLogPaths?: EvaluatorLogPaths, |
| this.evalLogSummaryLocation = logPaths.humanReadableSummary; | ||
| this.jsonEvalLogSummaryLocation = logPaths.jsonSummary; | ||
| this.evalLogSummarySymbolsLocation = logPaths.summarySymbols; | ||
| this.evalutorLogPaths = logPaths; |
Member
There was a problem hiding this comment.
Suggested change
| this.evalutorLogPaths = logPaths; | |
| this.evaluatorLogPaths = logPaths; |
Contributor
Author
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the fields from
EvaluatorLogPathswere copied 1:1 intoLocalQueryInfobut under different names. It seems easier to keep track of the different kinds of logs if they are called the same everywhere.