Skip to content

test: reduce and improve tests in src/compile/types.rs #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
May 22, 2026
Merged

test: reduce and improve tests in src/compile/types.rs #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/compile/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,14 +1553,7 @@ timeout-minutes: 60
assert_eq!(env.get("AWS_REGION").unwrap(), "us-west-2");
}

#[test]
fn test_engine_config_id_defaults_to_copilot() {
let yaml = "model: gpt-5\ntimeout-minutes: 30";
let opts: EngineOptions = serde_yaml::from_str(yaml).unwrap();
let ec = EngineConfig::Full(opts);
assert_eq!(ec.engine_id(), "copilot");
assert_eq!(ec.model(), Some("gpt-5"));
}


// ─── PermissionsConfig deserialization ───────────────────────────────

Expand Down Expand Up @@ -1807,12 +1800,14 @@ Body
let content = r#"---
name: "Test"
description: "Test"
tools:
edit: true
---

Body
"#;
let (fm, _) = super::super::common::parse_markdown(content).unwrap();
assert!(fm.tools.is_none());
assert!(fm.tools.as_ref().unwrap().azure_devops.is_none());
}

#[test]
Expand Down Expand Up @@ -1871,6 +1866,7 @@ Body
let (fm, _) = super::super::common::parse_markdown(content).unwrap();
let lean = fm.runtimes.as_ref().unwrap().lean.as_ref().unwrap();
assert!(!lean.is_enabled());
assert!(lean.toolchain().is_none());
}

#[test]
Expand Down Expand Up @@ -2010,6 +2006,12 @@ Body
result.is_err(),
"unknown fields in network should be rejected"
);
let err = format!("{:#}", result.unwrap_err());
assert!(
err.contains("typo-field") || err.contains("unknown field"),
"error should mention the unknown field, got: {}",
err
);
}

// ─── FrontMatter deny_unknown_fields ─────────────────────────────────────
Expand Down Expand Up @@ -2281,8 +2283,10 @@ triggers:
"#;
let val: serde_yaml::Value = serde_yaml::from_str(yaml).unwrap();
let tc: OnConfig = serde_yaml::from_value(val["triggers"].clone()).unwrap();
assert!(tc.pipeline.is_some());
assert!(tc.pr.is_some());
assert_eq!(
tc.pipeline.as_ref().unwrap().name,
"Build Pipeline"
);
assert_eq!(
tc.pr.unwrap().filters.unwrap().title.unwrap().pattern,
"*[review]*"
Expand Down