feat: add more tests and parse hunks a little differently #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the test files (0001-cross.patch) had an issue because empty whitespace lines are removed.
However, the old parser was looking for
+,-andto add a line to the hunk.With this modification, we try parsing until we find a next header and also take into account empty whitespace lines as context.
It will still fail on the example mentioned:
Where the
--- a;is interpreted as a "header".I tried a little bit to add range counting to the parser so that this case would also be fixed but I didn't finish that yet. I think it should be doable though :)