Don't error on empty input #14
Merged
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcefrog
force-pushed
the
13-empty-input
branch
from
a44434f to
f6b0133
Compare
sunjay
approved these changes
Dec 8, 2025
Contributor
sunjay
left a comment
sunjay
left a comment
There was a problem hiding this comment.
I don't remember why I made that decision 6 years ago and this seems reasonable, so approved. I don't maintain this crate, so you'll have to get the actual owner to merge and release your change.
sourcefrog
force-pushed
the
13-empty-input
branch
from
f6b0133 to
4b58f8c
Compare
This currently breaks CI in e.g. https://github.com/gitpatch-rs/gitpatch/actions/runs/20013661647/job/57387162629#step:5:70
sourcefrog
force-pushed
the
13-empty-input
branch
from
4b58f8c to
fc727b9
Compare
vrmiguel
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
It seems the previous behavior was intentional by @sunjay in b26abee but IMO it's a more difficult API. Parsing an empty string to an empty vec seems natural in Rust.