Support click v8.4#1260
Open
sirosen wants to merge 1 commit into
Open
Conversation
8.4 introduces relatively few changes, but does make `ParamType` a Generic parametrized over the return type of `convert()`. Unfortunately, we also support Python 3.9 , which means we must support older click versions. As such, `ParamType` is not even subscriptable on that version. To work around this, we use `TYPE_CHECKING` guards to split definitions between a generic and non-generic variant. Only one line of runtime code is changed: A superfluous call to `super().convert()` was flagged by `mypy` for having the wrong type and is here removed.
sirosen
requested review from
ada-globus,
derek-globus and
kurtmckee
as code owners
sirosen
requested review from
MaxTueckeGlobus,
aaschaer and
m1yag1
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.4 introduces relatively few changes, but does make
ParamTypeaGeneric parametrized over the return type of
convert(). Unfortunately,we also support Python 3.9 , which means we must support older click
versions. As such,
ParamTypeis not even subscriptable on that version.To work around this, we use
TYPE_CHECKINGguards to split definitionsbetween a generic and non-generic variant.
Only one line of runtime code is changed:
A superfluous call to
super().convert()was flagged bymypyforhaving the wrong type and is here removed.