remove plugin from generated import registry#140
Merged
Conversation
jfhamlin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
pluginfrom the generated import registry and regenerate the checked-inpkg/gen/gljimportsfiles.Why
pluginis not needed in the default package map, and keeping it in the generated registry forces external linking ondarwin/arm64.During investigation for issue #139, that external-link path consistently reproduced a Go linker panic when combined with glojure's large
clojure.coreAOT object. Removingpluginat the generator source removes that trigger from all generated targets.Impact
Glojure code will no longer resolve
plugin.*through the default generated package map.Validation
make glj-importsrg -n 'plugin\.|"plugin"|plugin/' cmd/gen-import-interop/main.go pkg/gen/gljimportsgo build ./cmd/glj