Skip to content

Conversation

@Lainow
Copy link
Contributor

@Lainow Lainow commented Dec 4, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !39740
  • Here is a brief description of what this PR does

Added the Document tab to the following models:

  • DatabaseInstance
  • Rack
  • ComputerModel
  • MonitorModel
  • NetworkEquipmentModel
  • PeripheralModel
  • PhoneModel
  • PrinterModel
  • DeviceGenericModel
  • AssetModel

It is now possible to add documents to all of these models.

Screenshots (if appropriate):

@Lainow Lainow self-assigned this Dec 4, 2025
@cedric-anne cedric-anne changed the title Add documents tab to a fex models Add documents tab to a few models Dec 4, 2025
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think custom asset models should also be added automatically to $CFG_GLPI['document_types'].

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the document tab to asset definitions, but it should rather be added to Glpi\Asset\AssetModel concrete classes.

@cedric-anne cedric-anne modified the milestones: 11.0.5, 12.0.0 Dec 11, 2025
@Lainow Lainow requested a review from cedric-anne December 15, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants